Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent worker without binary dependency #517

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Commits on Dec 10, 2020

  1. Configuration menu
    Copy the full SHA
    4ade8fb View commit details
    Browse the repository at this point in the history
  2. add program path to args as well.

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    792c9cc View commit details
    Browse the repository at this point in the history
  3. actually, the program path should be separate to make it easy in the …

    …non-persistent case
    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    c63874f View commit details
    Browse the repository at this point in the history
  4. add original process wrapper to tools depset

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    3c70076 View commit details
    Browse the repository at this point in the history
  5. enable incremental compilation

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    fe5d450 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fe33b0e View commit details
    Browse the repository at this point in the history
  7. pass workspace name to create cache dir

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    ef4335c View commit details
    Browse the repository at this point in the history
  8. clean up

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    64374bc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5307036 View commit details
    Browse the repository at this point in the history
  10. add the worker as a toolchain

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    27d5787 View commit details
    Browse the repository at this point in the history
  11. make workers optional

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    77e5a8b View commit details
    Browse the repository at this point in the history
  12. Fix toolchain registration

    Repositories should always be registered.
    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    4ee975c View commit details
    Browse the repository at this point in the history
  13. oops! Toolchain order matters.

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    6ffb3f9 View commit details
    Browse the repository at this point in the history
  14. update proto rules toolchains

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    22e7231 View commit details
    Browse the repository at this point in the history
  15. Remove TODO

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    14951fd View commit details
    Browse the repository at this point in the history
  16. Fix rebase issues

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    8aaf605 View commit details
    Browse the repository at this point in the history
  17. Run buildifier

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    4d71eca View commit details
    Browse the repository at this point in the history
  18. Fix documentation generation

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    eceab64 View commit details
    Browse the repository at this point in the history
  19. Change examples to use the worker

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    e3ccbf2 View commit details
    Browse the repository at this point in the history
  20. Fix buildifier lints

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    d4ccf6b View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    9f8d5ec View commit details
    Browse the repository at this point in the history
  22. Final buildifier fix

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    9952f2a View commit details
    Browse the repository at this point in the history
  23. Add documentation about using the worker

    nikhilm authored and dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    83fd96b View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    6f41239 View commit details
    Browse the repository at this point in the history
  25. use cargo to bootstrap worker

    The regular rust_binary() and rust_library() rules require a worker
    toolchain, even if it is a dummy one. This prevents us from using
    these rules to build the worker binary, as it leads to a cyclic
    dependency.
    
    Distributing an external binary is not ideal - it's hard to verify
    what it's doing, and awkward to add on new platforms. To work around
    this, we invoke cargo directly, using the configured toolchain. This
    causes cargo to fetch the dependencies directly, and
    build the worker binary which we can then use for future compilation.
    dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    71d240b View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c64cac0 View commit details
    Browse the repository at this point in the history
  27. declare a separate workspace

    Windows builds without a sandbox, and the calling Bazel workspace
    is higher up in the path, so if it has a Cargo workspace it breaks
    the build.
    dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    3cc55b7 View commit details
    Browse the repository at this point in the history
  28. hack in Windows support

    This is an ugly hack, and hopefully can be done in a nicer way.
    dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    1a0f6a1 View commit details
    Browse the repository at this point in the history
  29. declare target dir

    Otherwise with a local executor (eg Windows), we end up placing
    build products into the source tree.
    dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    69362cc View commit details
    Browse the repository at this point in the history
  30. update worker docs

    dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    f730bb6 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    4b09b64 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    d6e2a68 View commit details
    Browse the repository at this point in the history
  33. use a config flag to enable/disable worker

    This lets us enable/disable the worker from the command line or
    .bazelrc, and allows us to avoid a separate dummy toolchain.
    dae committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    81282ad View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    7b0201e View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    a0e3069 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Configuration menu
    Copy the full SHA
    cf71d13 View commit details
    Browse the repository at this point in the history
  2. Regenerate documentation

    dae committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    9ec3fc2 View commit details
    Browse the repository at this point in the history
  3. emphasize the experimental aspect

    dae committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    d8a5dcb View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Configuration menu
    Copy the full SHA
    16b3e6d View commit details
    Browse the repository at this point in the history