-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent worker without binary dependency #517
Open
dae
wants to merge
39
commits into
bazelbuild:main
Choose a base branch
from
ankitects:persistentworker2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4ade8fb - Browse repository at this point
Copy the full SHA 4ade8fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 792c9cc - Browse repository at this point
Copy the full SHA 792c9ccView commit details -
actually, the program path should be separate to make it easy in the …
…non-persistent case
Configuration menu - View commit details
-
Copy full SHA for c63874f - Browse repository at this point
Copy the full SHA c63874fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c70076 - Browse repository at this point
Copy the full SHA 3c70076View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe5d450 - Browse repository at this point
Copy the full SHA fe5d450View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe33b0e - Browse repository at this point
Copy the full SHA fe33b0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef4335c - Browse repository at this point
Copy the full SHA ef4335cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64374bc - Browse repository at this point
Copy the full SHA 64374bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5307036 - Browse repository at this point
Copy the full SHA 5307036View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27d5787 - Browse repository at this point
Copy the full SHA 27d5787View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77e5a8b - Browse repository at this point
Copy the full SHA 77e5a8bView commit details -
Repositories should always be registered.
Configuration menu - View commit details
-
Copy full SHA for 4ee975c - Browse repository at this point
Copy the full SHA 4ee975cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ffb3f9 - Browse repository at this point
Copy the full SHA 6ffb3f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22e7231 - Browse repository at this point
Copy the full SHA 22e7231View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14951fd - Browse repository at this point
Copy the full SHA 14951fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aaf605 - Browse repository at this point
Copy the full SHA 8aaf605View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d71eca - Browse repository at this point
Copy the full SHA 4d71ecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for eceab64 - Browse repository at this point
Copy the full SHA eceab64View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3ccbf2 - Browse repository at this point
Copy the full SHA e3ccbf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4ccf6b - Browse repository at this point
Copy the full SHA d4ccf6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f8d5ec - Browse repository at this point
Copy the full SHA 9f8d5ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9952f2a - Browse repository at this point
Copy the full SHA 9952f2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83fd96b - Browse repository at this point
Copy the full SHA 83fd96bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f41239 - Browse repository at this point
Copy the full SHA 6f41239View commit details -
The regular rust_binary() and rust_library() rules require a worker toolchain, even if it is a dummy one. This prevents us from using these rules to build the worker binary, as it leads to a cyclic dependency. Distributing an external binary is not ideal - it's hard to verify what it's doing, and awkward to add on new platforms. To work around this, we invoke cargo directly, using the configured toolchain. This causes cargo to fetch the dependencies directly, and build the worker binary which we can then use for future compilation.
Configuration menu - View commit details
-
Copy full SHA for 71d240b - Browse repository at this point
Copy the full SHA 71d240bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c64cac0 - Browse repository at this point
Copy the full SHA c64cac0View commit details -
Windows builds without a sandbox, and the calling Bazel workspace is higher up in the path, so if it has a Cargo workspace it breaks the build.
Configuration menu - View commit details
-
Copy full SHA for 3cc55b7 - Browse repository at this point
Copy the full SHA 3cc55b7View commit details -
This is an ugly hack, and hopefully can be done in a nicer way.
Configuration menu - View commit details
-
Copy full SHA for 1a0f6a1 - Browse repository at this point
Copy the full SHA 1a0f6a1View commit details -
Otherwise with a local executor (eg Windows), we end up placing build products into the source tree.
Configuration menu - View commit details
-
Copy full SHA for 69362cc - Browse repository at this point
Copy the full SHA 69362ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for f730bb6 - Browse repository at this point
Copy the full SHA f730bb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b09b64 - Browse repository at this point
Copy the full SHA 4b09b64View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6e2a68 - Browse repository at this point
Copy the full SHA d6e2a68View commit details -
use a config flag to enable/disable worker
This lets us enable/disable the worker from the command line or .bazelrc, and allows us to avoid a separate dummy toolchain.
Configuration menu - View commit details
-
Copy full SHA for 81282ad - Browse repository at this point
Copy the full SHA 81282adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b0201e - Browse repository at this point
Copy the full SHA 7b0201eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0e3069 - Browse repository at this point
Copy the full SHA a0e3069View commit details
Commits on Dec 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for cf71d13 - Browse repository at this point
Copy the full SHA cf71d13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ec3fc2 - Browse repository at this point
Copy the full SHA 9ec3fc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8a5dcb - Browse repository at this point
Copy the full SHA d8a5dcbView commit details
Commits on Dec 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 16b3e6d - Browse repository at this point
Copy the full SHA 16b3e6dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.