Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust 1.56.0 #982

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Add Rust 1.56.0 #982

merged 2 commits into from
Oct 22, 2021

Conversation

kalcutter
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 21, 2021
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@kalcutter
Copy link
Contributor Author

Is the failing test related to this change or a flaky test?

@UebelAndre
Copy link
Collaborator

Did something change about the way rustc handles linker args in 1.56.0? I haven't yet checked the docs but I don't think this is a flake.

  = note: "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/link.exe" "/NOLOGO" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.0.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.1.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.2.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.3.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.4.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.5.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.6.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.7.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.custom_name.d5f14f22-cgu.8.rcgu.o" "bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name\\custom_name.2a1gr5prt2tb19bt.rcgu.o" "/LIBPATH:external/rust_windows_x86_64/lib/rustlib/x86_64-pc-windows-msvc/lib" "/LIBPATH:C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-137462619eb7fb6e.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-40325f74f03cd910.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd_detect-d499ddbe6ea217f2.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_demangle-ac7fd557a0876ac7.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libhashbrown-e027da3f3243b8cb.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-d92ff4ce4e9ba04b.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-0fbe2e0a0cce010b.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcfg_if-994c4132e0b038fc.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liblibc-37b7cfcd70f86ebc.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-598a66e79671d548.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_core-b40eca52864f4eec.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-3200edb0d039ab3a.rlib" "C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-b0e0bca0e70300a2.rlib" "kernel32.lib" "ws2_32.lib" "advapi32.lib" "userenv.lib" "kernel32.lib" "msvcrt.lib" "/NXCOMPAT" "/LIBPATH:C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "/OUT:bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name/custom-crate-name-binary.exe" "/OPT:REF,NOICF" "/DEBUG" "/NATVIS:C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\etc\\libcore.natvis" "/NATVIS:C:\\b\\z6pqaalm\\external\\rust_windows_x86_64\\lib\\rustlib\\etc\\libstd.natvis" "/nologo" "/SUBSYSTEM:CONSOLE" "/MACHINE:X64" "/DEFAULTLIB:msvcrt.lib" "/DEBUG:FASTLINK" "/INCREMENTAL:NO"
  = note: custom_name.custom_name.d5f14f22-cgu.5.rcgu.o : error LNK2019: unresolved external symbol _ZN4test16test_main_static17h62fa1ead88336634E referenced in function _ZN11custom_name4main17h602891565d5c1300E
          bazel-out/x64_windows-fastbuild/bin/test/unit/crate_name/custom-crate-name-binary.exe : fatal error LNK1120: 1 unresolved externals

@kalcutter
Copy link
Contributor Author

Rust 1.56.0 uses LLVM 13 and there is this: rust-lang/rust#88227
However, I was under the impression link.exe is forgiving with respect to the order of libraries. I don't have easy access to a Windows machine at the moment to look into this further.

@kalcutter
Copy link
Contributor Author

Actually this test failed similarly in another recent PR: https://buildkite.com/bazel/rules-rust-rustlang/builds/4578#e62045d2-f206-458a-b1e5-57d0a88e4824
I think this is a flake. Can we merge?

@UebelAndre
Copy link
Collaborator

I don't have that kind of merging power. @hlopko Any thoughts here?

@UebelAndre UebelAndre merged commit 555b521 into bazelbuild:main Oct 22, 2021
@UebelAndre
Copy link
Collaborator

Seems like it was indeed a flake! Sorry I ever doubted 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants