Add the swift_common.use_toolchain() helper
#1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
This function currently returns an empty list so that adding it to the rules/aspects is a no-op. A future change will have it return a list containing the Swift toolchain type, enabling new toolchain resolution. PiperOrigin-RevId: 471075965 (cherry picked from commit 016604d) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/add-the-swift_common.use_toolchain-helper
branch
from
2831d71
to
bcfa554
Compare
luispadron
approved these changes
Jun 21, 2024
brentleyjones
referenced
this pull request
Jun 21, 2024
This function currently returns an empty list so that adding it to the rules/aspects is a no-op. A future change will have it return a list containing the Swift toolchain type, enabling new toolchain resolution. PiperOrigin-RevId: 471075965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function currently returns an empty list so that adding it to the rules/aspects is a no-op. A future change will have it return a list containing the Swift toolchain type, enabling new toolchain resolution.
PiperOrigin-RevId: 471075965
(cherry picked from commit 016604d)