Add the module_mapping flag to the Swift rules
#1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 3, 2024
The value of this flag should be the label a `swift_module_mapping` target, which provides the aliases to use during the build. At this time, module aliases are only being supported as a globally-applied build flag. This can be revisited in the future if aliases are needed for individual subgraphs, but this is much more complex to represent in BUILD. This change only adds the flag and hooks it into the toolchain; the compilation changes will be added in a subsequent change. PiperOrigin-RevId: 486659250
The value of this flag should be the label a `swift_module_mapping` target, which provides the aliases to use during the build. At this time, module aliases are only being supported as a globally-applied build flag. This can be revisited in the future if aliases are needed for individual subgraphs, but this is much more complex to represent in BUILD. This change only adds the flag and hooks it into the toolchain; the compilation changes will be added in a subsequent change. PiperOrigin-RevId: 486659250 (cherry picked from commit a80cea9) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/add-the-module_mapping-flag-to-the-swift-rules
branch
from
aeed2a8
to
733e97e
Compare
luispadron
approved these changes
Oct 3, 2024
brentleyjones
deleted the
bj/add-the-module_mapping-flag-to-the-swift-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of this flag should be the label a
swift_module_mappingtarget, which provides the aliases to use during the build.At this time, module aliases are only being supported as a globally-applied build flag. This can be revisited in the future if aliases are needed for individual subgraphs, but this is much more complex to represent in BUILD.
This change only adds the flag and hooks it into the toolchain; the compilation changes will be added in a subsequent change.
PiperOrigin-RevId: 486659250
(cherry picked from commit a80cea9)