Enable AccessLevelOnImport by default
#1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature also makes it an error for `.swiftinterface` files to publicly import non-resilient modules, so I've updated our `.swiftinterface` test case to stop depending on Foundation, which is not resilient on Linux. PiperOrigin-RevId: 640123191 (cherry picked from commit b5230b0) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 15, 2024
This feature also makes it an error for `.swiftinterface` files to publicly import non-resilient modules, so I've updated our `.swiftinterface` test case to stop depending on Foundation, which is not resilient on Linux. PiperOrigin-RevId: 640123191
luispadron
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature also makes it an error for
.swiftinterfacefiles to publicly import non-resilient modules, so I've updated our.swiftinterfacetest case to stop depending on Foundation, which is not resilient on Linux.PiperOrigin-RevId: 640123191
(cherry picked from commit b5230b0)