Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in MakeDirs #644

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Fix race condition in MakeDirs #644

merged 5 commits into from
Jun 10, 2021

Commits on Jun 10, 2021

  1. Fix race condition in MakeDirs 

    If there are 2 concurrent processes creating the same directories, then it will fail

I noticed this on the CI errors of bazelbuild#567, and a co-worker was hitting it
today. I suspect invalidating the worker or other updates triggered big
rebuilds.

I don't know of a perfect repro but, at a 10% rate: invoking Bazel to
build 2 swift libraries in the same BUILD file.
    @jerrymarino
    jerrymarino committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    64dbf25 View commit details
    Browse the repository at this point in the history

  2. Improve comments - add more checks unexpected file 

    Also remove unneeded call access: the NetBSD and coreutils mkdir
implementationsa are just checking errno from `mkdir`
    @jerrymarino
    jerrymarino committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    2ca5cfa View commit details
    Browse the repository at this point in the history

  3. Update tools/common/file_system.cc 

    Co-authored-by: Brentley Jones <github@brentleyjones.com>
    @jerrymarino @brentleyjones
    jerrymarino and brentleyjones committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9a4447f View commit details
    Browse the repository at this point in the history

  4. Fix linux compiler issue

    @jerrymarino
    jerrymarino committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    828de08 View commit details
    Browse the repository at this point in the history

  5. Update tools/common/file_system.cc 

    Co-authored-by: Brentley Jones <github@brentleyjones.com>
    @jerrymarino @brentleyjones
    jerrymarino and brentleyjones committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    af7aedb View commit details
    Browse the repository at this point in the history