Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to pass strict dependency include paths from the apple_common.Objc provider when compiling the explicit module for a target. #675

Conversation

thii
Copy link
Member

@thii thii commented Aug 17, 2021

Also clarify the purpose of the compilation_context argument in swift_common.create_clang_module and how it should and should not be used.

PiperOrigin-RevId: 391067469
(cherry picked from commit a81c591)

Conflicts:
swift/internal/swift_clang_module_aspect.bzl

@google-cla
Copy link

google-cla bot commented Aug 17, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 17, 2021
…mon.Objc` provider when compiling the explicit module for a target.

Also clarify the purpose of the `compilation_context` argument in `swift_common.create_clang_module` and how it should and should not be used.

PiperOrigin-RevId: 391067469
(cherry picked from commit a81c591)

 Conflicts:
	swift/internal/swift_clang_module_aspect.bzl
@thii thii force-pushed the make-sure-to-pass-strict-dependency-include-paths-from-the-apple_common.objc-provider-when-compiling-the-explicit-module-for-a-target branch from 751d8a5 to 07cc624 Compare August 17, 2021 01:44
@google-cla
Copy link

google-cla bot commented Aug 17, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@thii thii marked this pull request as ready for review August 17, 2021 02:18
thii referenced this pull request Aug 17, 2021
…mon.Objc` provider when compiling the explicit module for a target.

Also clarify the purpose of the `compilation_context` argument in `swift_common.create_clang_module` and how it should and should not be used.

PiperOrigin-RevId: 391067469
@thii thii merged commit 4a38722 into bazelbuild:master Aug 18, 2021
@thii thii deleted the make-sure-to-pass-strict-dependency-include-paths-from-the-apple_common.objc-provider-when-compiling-the-explicit-module-for-a-target branch August 18, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants