This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
fix: ts_auto_deps workaround for https://github.com/bazelbuild/bazel/issues/3325 no longer needed #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
requested review from
alexeagle,
kyliau and
mgechev
as code owners
|
sent a g3sync to @LucasSloan |
alexeagle
approved these changes
Aug 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of bazel-contrib/rules_nodejs#1042.
--direct_runis now enabled by default in Bazel (bazelbuild/bazel#3325 (comment)) so this work-around is no longer needed. The work-around was creating an issue as it was forcing ts_auto_deps to run in theBUILD_WORKING_DIRECTORYin the//e2e:e2e_ts_auto_depstest that was callingbazel run @nodejs//:bin/yarn -- generate_build_filehere: https://github.com/bazelbuild/rules_nodejs/pull/1042/files#diff-e90fea9ba9d188bc0409725ef3b89eb0