Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit dependency on protobuf #221

Merged
merged 1 commit into from
May 14, 2024
Merged

Remove explicit dependency on protobuf #221

merged 1 commit into from
May 14, 2024

Commits on May 14, 2024

  1. Remove explicit dependency on protobuf 

    With `--incompatible_enable_proto_toolchain_resolution`, the root module is supposed to provide a `proto_lang_toolchain` for Java, which injects the runtime. Hardcoded dependencies on the `protobuf` module would negate the benefits of supplying a toolchain with precompiled `protoc` and runtime.

Since the only used symbol from the protobuf runtime was an exception class, it has been replaced with a check for its class name. If more protobuf runtime symbols should be needed in the future, they should be obtained from a `current_java_proto_runtime` target that first looks for a `proto_lang_toolchain` for Java and only then falls back to the hardcoded reference.
    @fmeum
    fmeum committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c0f93dd View commit details
    Browse the repository at this point in the history