Update spec from google/starlark-go #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laurentlb
commented
Sep 24, 2020
•
laurentlb
commented
- document call argument evaluation order
- load statements create local bindings
- Rename "universe" to "predeclared"
- hash: allow only strings
- Add TOC
This aligns the spec with google/starlark-go#198
alandonovan
approved these changes
Sep 24, 2020
| @@ -463,8 +463,7 @@ values include `None`, Booleans, numbers, and strings, and tuples | |||
| composed from hashable values. Most mutable values, such as lists, | |||
| and dictionaries, are not hashable, unless they are frozen. | |||
| Attempting to use a non-hashable value as a key in a dictionary | |||
| results in a dynamic error, as does passing one to the built-in | |||
| `hash` function. | |||
| results in a dynamic error. | |||
There was a problem hiding this comment.
I think the old text was correct (does that mean this change needs to flow in the other direction?).
Both hash implementations accept only string, not list, say.
There was a problem hiding this comment.
I think that's correct.
The old text said it's an error to pass a non-hashable value to hash. This might be technically true, but that's irrelevant since hash accepts only strings. No need to mention hash here.
| @@ -463,8 +463,7 @@ values include `None`, Booleans, numbers, and strings, and tuples | |||
| composed from hashable values. Most mutable values, such as lists, | |||
There was a problem hiding this comment.
I noticed that the TOC that exists in Go spec has vanished from bazelbuild. Could you restore it?
(this aligns with the doc in google/starlark-go)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.