Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-- #20

Closed
wants to merge 3 commits into from
Closed

-- #20

wants to merge 3 commits into from

Conversation

thom4parisot
Copy link
Contributor

Content moved in #32

@Integralist
Copy link
Contributor

@oncletom Sounds good. I'll start going through each proposal and will feedback any thoughts I have. If I think any one proprosal is good enough to be started (without me needing to comment or make suggestions for change) then I'll say so in the comment and then close the issue so we know that it's OK to go ahead.

Otherwise the proposals will stay as open issues so we can continue discussions. Hope that all sounds OK?

@Integralist
Copy link
Contributor

@oncletom Actually, correcting myself... even if I do like the issue raised I will comment on it to say so (as I suggested above) but I'll leave the issue open until a separate PR has actually been made (and merged) that way I know it's a still outstanding issue.

@thom4parisot
Copy link
Contributor Author

That's perfect :-)

Actually with the hub program, it is possible to transform an issue in a PR so it will be quite easy to have both discussions and code in the same issue.

@Integralist
Copy link
Contributor

@oncletom awesome! that's good :-)

@thom4parisot
Copy link
Contributor Author

Actually I don't want it to be merged in master, missed it ;-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thom4parisot @Integralist