Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging changes from pietro's master branch #94

Open
wants to merge 189 commits into
base: master
Choose a base branch
from

Conversation

emettely
Copy link
Contributor

@emettely emettely commented Mar 9, 2020

Is your Pull Request request related to another issue in this repository ?

Describe what the PR does
Merges Pietro's master branch of client. This will pull in changes such as updating of dependencies from forks and getting the newest changes of the UI compositions.

State whether the PR is ready for review or whether it needs extra work
This will not be merged - as BBC is currently not actively developing the client. We have a firebase version of the application, which doesn't actually utilise the client, but refers to the client from the component compositions. The best approach to pull in the changes is looking at Pietro's changes, and manually implementing the compositions.

Additional context

Pietro Passarelli added 30 commits May 21, 2020 20:50
fixed typo
save btn disabled when click save, while waiting for upload, whileupload is in progress, until upload is done, then modal is closed
compatibility with voice memo files upload
update slate transcript editor with better alignment
updating slate transcript editor
updating slate-transcript-editor
updating slate-transcript-editor
updating slate-transcript-editor
fixed navigation

there was an issue where going to paper edit page broke navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants