-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging changes from pietro's master branch #94
Open
emettely
wants to merge
189
commits into
bbc:master
Choose a base branch
from
pietrop:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after npm install
brought it back to working order
added support for Audition XML
from save to server to saved
setup for Adobe CEP Panel integration
removed change dir command in CEP integration as it doesn't seem support anymore
re introduced process.chdir
Adobe CEP new transcript form integration test
fixing logic
fixed typo
save btn disabled when click save, while waiting for upload, whileupload is in progress, until upload is done, then modal is closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Describe what the PR does
Merges Pietro's master branch of client. This will pull in changes such as updating of dependencies from forks and getting the newest changes of the UI compositions.
State whether the PR is ready for review or whether it needs extra work
This will not be merged - as BBC is currently not actively developing the client. We have a firebase version of the application, which doesn't actually utilise the client, but refers to the client from the component compositions. The best approach to pull in the changes is looking at Pietro's changes, and manually implementing the compositions.
Additional context