Skip to content

Commit

Permalink
Make Emscripten SDK (emsdk) version a workflow input
Browse files Browse the repository at this point in the history
Closes #143
  • Loading branch information
sungaila authored and bblanchon committed Nov 14, 2023
1 parent e2cb2b3 commit 60429bf
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/build-one.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ on:
type: boolean
required: false
default: false
emsdk_version:
description: Emscripten SDK
type: string
required: false
default: 3.1.34
is_debug:
description: Is debug
type: boolean
Expand All @@ -59,3 +64,4 @@ jobs:
target_cpu: ${{ github.event.inputs.target_cpu }}
target_libc: ${{ github.event.inputs.target_libc }}
enable_v8: ${{ github.event.inputs.enable_v8 == 'true' }}
emsdk_version: ${{ github.event.inputs.emsdk_version }}
6 changes: 6 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ on:
type: string
required: false
default: ''
emsdk_version:
description: Emscripten SDK
type: string
required: false
default: 3.1.34
outputs:
artifact:
description: "The name of the artifact"
Expand Down Expand Up @@ -76,6 +81,7 @@ jobs:
PDFium_TARGET_LIBC=${{ inputs.target_libc }}
PDFium_ENABLE_V8=${{ inputs.enable_v8 }}
PDFium_VERSION=${{ inputs.version }}
EMSDK_VERSION=${{ inputs.emsdk_version }}
MUSL_URL=${{ secrets.MUSL_URL }}
END
steps/00-environment.sh
Expand Down
4 changes: 2 additions & 2 deletions steps/01-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ case "$TARGET_OS" in
git clone https://github.com/emscripten-core/emsdk.git
fi
pushd emsdk
./emsdk install 3.1.34
./emsdk activate 3.1.34
./emsdk install ${EMSDK_VERSION:-3.1.34}
./emsdk activate ${EMSDK_VERSION:-3.1.34}
echo "$PWD/upstream/emscripten" >> "$PATH_FILE"
echo "$PWD/upstream/bin" >> "$PATH_FILE"
popd
Expand Down

0 comments on commit 60429bf

Please sign in to comment.