Skip to content

Commit

Permalink
change -Wall and -Wno-unused-result order for frontier builds to redu…
Browse files Browse the repository at this point in the history
…ce warnings
  • Loading branch information
alwinm committed Dec 21, 2022
1 parent 379b86e commit 9ea7336
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ ifdef HIPCONFIG
DFLAGS += -DO_HIP
CXXFLAGS += $(HIPCONFIG)
GPUCXX ?= hipcc
GPUFLAGS += -Wall
#GPUFLAGS += -Wall
LD := $(CXX)
LDFLAGS := $(CXXFLAGS) -L$(ROCM_PATH)/lib
LIBS += -lamdhip64
Expand Down
4 changes: 2 additions & 2 deletions builds/make.host.frontier
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ CFLAGS_OPTIMIZE = -g -O2
CXXFLAGS_DEBUG = -g -O0 -std=c++17
CXXFLAGS_OPTIMIZE = -g -Ofast -std=c++17 -Wno-unused-result

GPUFLAGS_OPTIMIZE = -std=c++17 --offload-arch=gfx90a -Wno-unused-result
GPUFLAGS_DEBUG = -g -O0 -std=c++17 --offload-arch=gfx90a -Wno-unused-result
GPUFLAGS_OPTIMIZE = -std=c++17 --offload-arch=gfx90a -Wall -Wno-unused-result
GPUFLAGS_DEBUG = -g -O0 -std=c++17 --offload-arch=gfx90a -Wall -Wno-unused-result
HIPCONFIG = -I$(ROCM_PATH)/include $(shell hipconfig -C) # workaround for Rocm 5.2 warnings
#HIPCONFIG = $(shell hipconfig -C)

Expand Down
2 changes: 1 addition & 1 deletion src/grid/initial_conditions.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*! \file initial_conditions.cpp
/* \brief Definitions of initial conditions for different tests.
* \brief Definitions of initial conditions for different tests.
Note that the grid is mapped to 1D as i + (x_dim)*j + (x_dim*y_dim)*k.
Functions are members of the Grid3D class. */

Expand Down

0 comments on commit 9ea7336

Please sign in to comment.