Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lyrics page #527

Merged
merged 36 commits into from
Nov 22, 2024
Merged

feat: lyrics page #527

merged 36 commits into from
Nov 22, 2024

Conversation

sifferhans
Copy link
Collaborator

No description provided.

@sifferhans sifferhans mentioned this pull request Nov 12, 2024
Closed
5 tasks
@sifferhans sifferhans marked this pull request as ready for review November 13, 2024 15:56
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 490 lines in your changes missing coverage. Please review.

Project coverage is 6.77%. Comparing base (e1d2afe) to head (e725cd8).
Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
pages/lyrics/[id].vue 0.00% 220 Missing and 1 partial ⚠️
pages/lyrics/index.vue 0.00% 97 Missing and 1 partial ⚠️
components/LyricsEditor.vue 0.00% 82 Missing and 1 partial ⚠️
components/ComboSearchBox.vue 0.00% 76 Missing and 1 partial ⚠️
components/sidebar/SidebarElement.vue 0.00% 6 Missing ⚠️
utils/roles.ts 0.00% 4 Missing ⚠️
components/ButtonStyled.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #527      +/-   ##
========================================
- Coverage   8.29%   6.77%   -1.53%     
========================================
  Files        160     175      +15     
  Lines       9244   11321    +2077     
  Branches     281     296      +15     
========================================
  Hits         767     767              
- Misses      8322   10384    +2062     
- Partials     155     170      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

kkuepper
kkuepper reviewed Nov 13, 2024
View reviewed changes
pages/lyrics/[id].vue Outdated Show resolved Hide resolved
kkuepper
kkuepper reviewed Nov 13, 2024
View reviewed changes
pages/lyrics/[id].vue Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2024
View reviewed changes
utils/lyricsEditor.ts Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2024
View reviewed changes
utils/lyricsEditor.ts Dismissed Show dismissed Hide dismissed
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

@kkuepper kkuepper merged commit 2964ca4 into main Nov 22, 2024
12 checks passed
@kkuepper kkuepper deleted the feature/lyrics-page branch November 22, 2024 16:34
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-527.westeurope.3.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkuepper kkuepper kkuepper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sifferhans @kkuepper