Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新クトゥルフ(およびパルプクトゥルフ)の連射コマンドのバグ修正 #148

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

AdmiralNyar
Copy link
Contributor

変更内容

貫通時の切り捨てと切り上げが逆になっていた点を修正

https://github.com/AdmiralNyar/BCDice/blob/9eb674c3fa1467d0076fc38017a276f645ce4d60/src/diceBot/Cthulhu7th.rb#L364-L380

ボレーの最小は3との記述を見逃していた点を修正

https://github.com/AdmiralNyar/BCDice/blob/9eb674c3fa1467d0076fc38017a276f645ce4d60/src/diceBot/Cthulhu7th.rb#L423-L445

貫通する弾丸の数は、”ボレーの半分ではなくその判定をしている弾丸の数の半分”であった点を修正

https://github.com/AdmiralNyar/BCDice/blob/9eb674c3fa1467d0076fc38017a276f645ce4d60/src/diceBot/Cthulhu7th.rb#L379

命中という表現をより正しい通常命中に修正

https://github.com/AdmiralNyar/BCDice/blob/9eb674c3fa1467d0076fc38017a276f645ce4d60/src/diceBot/Cthulhu7th.rb#L337

上記修正に合わせてテストデータを修正・追加

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #148 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   86.27%   86.26%   -0.01%     
==========================================
  Files         198      198              
  Lines       22127    22126       -1     
==========================================
- Hits        19089    19088       -1     
  Misses       3038     3038              
Impacted Files Coverage Δ
src/diceBot/Cthulhu7th.rb 99.58% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e70b47...9eb674c. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ysakasin ysakasin merged commit cb0055e into bcdice:master Apr 3, 2020
@AdmiralNyar AdmiralNyar deleted the CoC7th_Debug branch April 4, 2020 09:22
ysakasin pushed a commit that referenced this pull request Aug 30, 2020
* 新クトゥルフの連射コマンドのバグ修正

* 新クトゥルフの連射コマンドのバグ修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants