Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArsMagicaで成功失敗判定ができない問題を修正 #167

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

ysakasin
Copy link
Member

ArsMagicaのテストで成功失敗判定のテストケースがなかったため、 DiceBot#check_result のリファクタリング(#145)で修正漏れしていた。

問題を修正し、該当するテストケースを追加。
また、重複するテストケースを排除。

@ysakasin ysakasin added the bug バグってる! label Apr 29, 2020
@ysakasin ysakasin requested a review from ochaochaocha3 April 29, 2020 04:50
@codecov-io
Copy link

Codecov Report

Merging #167 into master will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   86.21%   86.61%   +0.40%     
==========================================
  Files         199      204       +5     
  Lines       21072    21657     +585     
==========================================
+ Hits        18167    18759     +592     
+ Misses       2905     2898       -7     
Impacted Files Coverage Δ
src/diceBot/ArsMagica.rb 93.82% <100.00%> (+18.55%) ⬆️
src/diceBot/YearZeroEngine.rb 97.22% <0.00%> (ø)
src/dice/add_dice/node.rb 99.14% <0.00%> (ø)
src/test/add_dice_parser_test.rb 100.00% <0.00%> (ø)
src/dice/add_dice/parser.rb 93.93% <0.00%> (ø)
src/dice/add_dice/randomizer.rb 88.52% <0.00%> (ø)
src/dice/AddDice.rb 90.69% <0.00%> (+0.35%) ⬆️
src/diceBot/DiceBot.rb 95.10% <0.00%> (+1.09%) ⬆️
src/bcdiceCore.rb 72.13% <0.00%> (+1.21%) ⬆️
src/diceBot/CthulhuTech.rb 100.00% <0.00%> (+1.40%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5042c...32514f3. Read the comment docs.

Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ysakasin ysakasin merged commit a161b6d into master Apr 29, 2020
@ysakasin ysakasin deleted the fix_ars_magica branch April 29, 2020 07:59
ysakasin added a commit that referenced this pull request Aug 30, 2020
ArsMagicaで成功失敗判定ができない問題を修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug バグってる!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants