Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

フタリソウサの韓国語対応 #194

Merged
merged 3 commits into from
May 16, 2020
Merged

フタリソウサの韓国語対応 #194

merged 3 commits into from
May 16, 2020

Conversation

ysakasin
Copy link
Member

@ysakasin ysakasin commented May 15, 2020

ミス部分は翻訳者に確認中
確認済み

@ysakasin ysakasin marked this pull request as ready for review May 16, 2020 03:07
@ysakasin ysakasin requested a review from ochaochaocha3 May 16, 2020 03:07
@ysakasin ysakasin added the new dicebot 新システムの対応 label May 16, 2020
@codecov-io
Copy link

codecov-io commented May 16, 2020

Codecov Report

Attention: Patch coverage is 96.98997% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (b0be3d7) to head (8e97ad9).
Report is 2547 commits behind head on master.

Files with missing lines Patch % Lines
src/diceBot/FutariSousa_Korean.rb 96.98% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   87.20%   87.01%   -0.20%     
==========================================
  Files         198      210      +12     
  Lines       20687    22174    +1487     
==========================================
+ Hits        18040    19294    +1254     
- Misses       2647     2880     +233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日本語版と同じ構造なので、問題ないです。

@ysakasin ysakasin merged commit 57ed031 into master May 16, 2020
@ysakasin ysakasin deleted the futarisousa_korean branch May 16, 2020 07:31
ysakasin added a commit that referenced this pull request Aug 30, 2020
フタリソウサの韓国語対応
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new dicebot 新システムの対応
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants