Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

スチームパンカーズを追加 #227

Merged
merged 2 commits into from
Jul 4, 2020
Merged

スチームパンカーズを追加 #227

merged 2 commits into from
Jul 4, 2020

Conversation

ysakasin
Copy link
Member

@ysakasin ysakasin commented Jul 2, 2020

DOHさんの寄稿

DOHさんの寄稿
@ysakasin ysakasin added the new dicebot 新システムの対応 label Jul 2, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #227 into master will decrease coverage by 1.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   87.62%   86.60%   -1.02%     
==========================================
  Files         217      218       +1     
  Lines       22420    23287     +867     
==========================================
+ Hits        19645    20168     +523     
- Misses       2775     3119     +344     
Impacted Files Coverage Δ
src/diceBot/SteamPunkers.rb 95.45% <95.45%> (ø)
src/configBcDice.rb 100.00% <0.00%> (ø)
src/cgiDiceBot.rb 65.28% <0.00%> (+2.54%) ⬆️
src/TableFileData.rb 34.72% <0.00%> (+3.17%) ⬆️
src/bcdiceCore.rb 85.11% <0.00%> (+3.77%) ⬆️
src/CardTrader.rb 19.86% <0.00%> (+4.29%) ⬆️
src/dice/RerollDice.rb 95.07% <0.00%> (+6.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbfd5b...520cdaa. Read the comment docs.

@ysakasin ysakasin marked this pull request as ready for review July 3, 2020 13:11
@ysakasin ysakasin requested a review from ochaochaocha3 July 3, 2020 13:11
Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ysakasin ysakasin merged commit cf8ead5 into master Jul 4, 2020
@ysakasin ysakasin deleted the steam_punkers branch July 4, 2020 07:29
ysakasin added a commit that referenced this pull request Aug 30, 2020
スチームパンカーズを追加
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new dicebot 新システムの対応
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants