Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year zero engine dicebotの修正と機能強化 #233

Merged
merged 5 commits into from
Jul 6, 2020
Merged

Year zero engine dicebotの修正と機能強化 #233

merged 5 commits into from
Jul 6, 2020

Conversation

FredGreenfield
Copy link
Contributor

以下の修正と機能強化を行いました。

  • camelCaseをsnake_caseに修正
  • ダイスボット名を英語に修正
  • 難易度を設定可能にし、結果出力を行うように機能強化
  • 6に加えてダイスの1とpush可能なダイス個数を数える詳細版コマンド追加

src/diceBot/YearZeroEngine.rb Outdated Show resolved Hide resolved
@FredGreenfield FredGreenfield requested a review from ysakasin July 6, 2020 15:38
@ysakasin ysakasin merged commit bc58c95 into bcdice:master Jul 6, 2020
@ysakasin
Copy link
Member

ysakasin commented Jul 6, 2020

ありがとうございます! マージしました

@FredGreenfield FredGreenfield deleted the year_zero_engine_dicebot branch July 6, 2020 21:42
ysakasin pushed a commit that referenced this pull request Aug 30, 2020
* camelCaseをsnake_caseに変更。

* 難易度を設定可能にし判定結果を出すように修正
ダイスボット名を英語に修正

* ダイスの1とpush可能個数をカウントする詳細版コマンドを追加

* Hash引数をRuby 1.9.3と1.8.7で通る記法に修正

* Hashをインスタンス変数に変更
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants