Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeadlineHeroesのリファクタリング #268

Merged
merged 4 commits into from
Aug 23, 2020
Merged

Conversation

ysakasin
Copy link
Member

No description provided.

@ysakasin ysakasin added the refactoring 内部構造の改良 label Aug 22, 2020
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #268 into master will decrease coverage by 0.00%.
The diff coverage is 97.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   87.88%   87.87%   -0.01%     
==========================================
  Files         225      225              
  Lines       22905    22903       -2     
==========================================
- Hits        20131    20127       -4     
- Misses       2774     2776       +2     
Impacted Files Coverage Δ
src/diceBot/DeadlineHeroes.rb 97.70% <97.32%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d5773...973321a. Read the comment docs.

@ysakasin ysakasin marked this pull request as ready for review August 23, 2020 07:56
@ysakasin ysakasin merged commit 9ed819f into master Aug 23, 2020
@ysakasin ysakasin deleted the refactor_DeadlineHeroes branch August 23, 2020 07:57
ysakasin added a commit that referenced this pull request Aug 30, 2020
DeadlineHeroesのリファクタリング
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 内部構造の改良
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant