Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

カムズの追加 #282

Merged
merged 2 commits into from
Nov 8, 2020
Merged

カムズの追加 #282

merged 2 commits into from
Nov 8, 2020

Conversation

raa0121
Copy link
Contributor

@raa0121 raa0121 commented Nov 5, 2020

https://www.karikariume.com/comes 同人TRPGシステムですが、作者から作成依頼があり、作りました。

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #282 (800e89d) into master (8e78db3) will decrease coverage by 0.04%.
The diff coverage is 98.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   93.68%   93.63%   -0.05%     
==========================================
  Files         250      254       +4     
  Lines       18284    18220      -64     
==========================================
- Hits        17130    17061      -69     
- Misses       1154     1159       +5     
Impacted Files Coverage Δ
lib/bcdice/game_system/LogHorizon.rb 98.71% <ø> (-0.97%) ⬇️
lib/bcdice/translate.rb 100.00% <ø> (ø)
lib/bcdice/base.rb 95.05% <94.11%> (-0.72%) ⬇️
lib/bcdice/game_system/Warhammer4.rb 96.07% <96.07%> (ø)
lib/bcdice/game_system/Cthulhu.rb 97.72% <96.20%> (+0.12%) ⬆️
lib/bcdice/common_command/add_dice.rb 100.00% <100.00%> (ø)
lib/bcdice/common_command/barabara_dice.rb 100.00% <100.00%> (ø)
lib/bcdice/common_command/calc.rb 100.00% <100.00%> (ø)
lib/bcdice/common_command/choice.rb 100.00% <100.00%> (ø)
lib/bcdice/common_command/d66_dice.rb 95.12% <100.00%> (+1.18%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e78db3...7907630. Read the comment docs.

@ysakasin ysakasin self-requested a review November 5, 2020 15:33
Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

寄稿ありがとうございます。

日本語以外の実装予定はないと思いますので、i18n機能は使わずに、従来通りRubyのソースコードにハードコードしてください。

lib/bcdice/game_system/Comes.rb Outdated Show resolved Hide resolved
@raa0121 raa0121 force-pushed the feature/system-comes branch from b018f3c to 8ab34a7 Compare November 8, 2020 11:10
@raa0121 raa0121 force-pushed the feature/system-comes branch from 8ab34a7 to 7907630 Compare November 8, 2020 11:19
@ysakasin ysakasin merged commit b20987a into bcdice:master Nov 8, 2020
@ysakasin
Copy link
Member

ysakasin commented Nov 8, 2020

@raa0121 寄稿ありがとうございます! マージしました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants