Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KillDeathBusiness] 修正値が前処理で負数になっても動くように #346

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

ysakasin
Copy link
Member

判定コマンドJDJD5+(1-2),4のように負数が前処理で展開されると動かない問題を修正。

Fix #272

@ysakasin ysakasin added the bug バグってる! label Dec 28, 2020
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #346 (0bb7763) into master (e4c4fe1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         263      263           
  Lines       18049    18055    +6     
=======================================
+ Hits        17044    17050    +6     
  Misses       1005     1005           
Impacted Files Coverage Δ
lib/bcdice/game_system/KillDeathBusiness.rb 96.61% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c4fe1...0bb7763. Read the comment docs.

@ysakasin ysakasin merged commit a7edf02 into master Dec 28, 2020
@ysakasin ysakasin deleted the fix_arithmetic_KillDeathBusiness branch December 28, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug バグってる!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

キルデスビジネス:難易度と補正値の区切り文字にカンマも使いたい
1 participant