Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

冒険企画局版の歯車の塔の探空士実装 #414

Merged
merged 6 commits into from
Apr 21, 2021
Merged

冒険企画局版の歯車の塔の探空士実装 #414

merged 6 commits into from
Apr 21, 2021

Conversation

GenKuzumochi
Copy link
Contributor

@GenKuzumochi GenKuzumochi commented Apr 12, 2021 •
edited
Loading

  • 歯車の塔の探空士 基本ルールブックを実装
  • 旧版のタイトルとソートキーを調整
  • テスト

@codecov
Copy link

codecov bot commented Apr 12, 2021 •
edited
Loading

Codecov Report

Merging #414 (2771d46) into master (e682318) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   95.06%   95.17%   +0.10%     
==========================================
  Files         284      287       +3     
  Lines       18519    18573      +54     
==========================================
+ Hits        17606    17677      +71     
+ Misses        913      896      -17
Impacted Files Coverage Δ
lib/bcdice/game_system.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/Skynauts.rb 99.40% <100.00%> (ø)
lib/bcdice/game_system/SkynautsBouken.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/IthaWenUa.rb 93.33% <0.00%> (-6.67%) ⬇️
lib/bcdice/game_system/WARPS.rb 94.44% <0.00%> (-5.56%) ⬇️
lib/bcdice/game_system/Elric.rb 95.45% <0.00%> (-4.55%) ⬇️
lib/bcdice/game_system/GundogRevised.rb 93.50% <0.00%> (-1.24%) ⬇️
lib/bcdice/game_system/Nechronica.rb 97.84% <0.00%> (-1.03%) ⬇️
lib/bcdice/game_system/Warhammer.rb 95.76% <0.00%> (-0.70%) ⬇️
lib/bcdice/game_system/KanColle.rb 87.01% <0.00%> (-0.65%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e682318...2771d46. Read the comment docs.

@GenKuzumochi GenKuzumochi marked this pull request as ready for review April 17, 2021 15:15
@GenKuzumochi
Copy link
Contributor Author

とりあえず一通り実装しました、レビューお願いいたします。

ysakasin
ysakasin requested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！
細かいところですが何点かコメントしました。
加えて、全てのメソッドをpublicにするのではなく、適宜 private を入れるように変更お願いします。

lib/bcdice/game_system/SkynautsBouken.rb Outdated Show resolved Hide resolved
lib/bcdice/game_system/SkynautsBouken.rb Outdated Show resolved Hide resolved
@GenKuzumochi
レビューを反映
ed4d1e1 
正規表現をわかりやすく
private化
不要な処理の削除
ysakasin
ysakasin requested changes Apr 20, 2021
View reviewed changes
lib/bcdice/game_system/SkynautsBouken.rb Outdated
'1D6', [
"なんとか大事にはいたらなかった。通常の失敗と同様の処理を行うこと。",
"転んでしまった。キミは[転倒](p107)する。",
"失敗にイライラしてしまった。キミた獲得している【キズナ】1つの「支援チェック」にチェックを入れる。",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

誤植だと思われるので確認お願いします。

ysakasin
ysakasin approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ysakasin ysakasin merged commit 5c5f3ed into bcdice:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysakasin ysakasin ysakasin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GenKuzumochi @ysakasin