Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BeastBindTrinity] Result対応 #432

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

h-mikisato
Copy link
Contributor

@h-mikisato h-mikisato commented Apr 27, 2021

#423 対応
クリティカル、ファンブル、成功失敗について、テキストに記載がある通りにResultに設定

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #432 (394bf66) into master (03262c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 394bf66 differs from pull request most recent head 43f6584. Consider uploading reports for the commit 43f6584 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         288      288           
  Lines       18650    18660   +10     
=======================================
+ Hits        17755    17765   +10     
  Misses        895      895           
Impacted Files Coverage Δ
lib/bcdice/game_system/BeastBindTrinity.rb 95.90% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03262c9...43f6584. Read the comment docs.

@ysakasin ysakasin merged commit 536ddeb into bcdice:master Apr 28, 2021
@ysakasin
Copy link
Member

ありがとうございます。マージしました。

@h-mikisato h-mikisato deleted the feature/bbt_result branch November 27, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants