Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fate Core System #499

Merged
merged 2 commits into from
Oct 16, 2021
Merged

Fate Core System #499

merged 2 commits into from
Oct 16, 2021

Conversation

ysakasin
Copy link
Member

No description provided.

@ysakasin ysakasin added the new dicebot 新システムの対応 label Sep 12, 2021
@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #499 (82f4077) into master (dadaffc) will decrease coverage by 0.15%.
The diff coverage is 98.42%.

❗ Current head 82f4077 differs from pull request most recent head f16d161. Consider uploading reports for the commit f16d161 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   95.59%   95.44%   -0.16%     
==========================================
  Files         297      311      +14     
  Lines       18898    18291     -607     
==========================================
- Hits        18065    17457     -608     
- Misses        833      834       +1     
Impacted Files Coverage Δ
lib/bcdice/game_system/BeginningIdol.rb 100.00% <ø> (+0.36%) ⬆️
lib/bcdice/game_system/BeginningIdol_Korean.rb 100.00% <ø> (+0.37%) ⬆️
lib/bcdice/dice_table/d66_table.rb 91.30% <33.33%> (-8.70%) ⬇️
...b/bcdice/game_system/beginning_idol/chain_table.rb 94.44% <94.44%> (ø)
...ib/bcdice/game_system/beginning_idol/work_table.rb 96.87% <96.87%> (ø)
...ice/game_system/beginning_idol/with_abnormality.rb 97.67% <97.67%> (ø)
lib/bcdice/game_system/FateCoreSystem.rb 98.14% <98.14%> (ø)
lib/bcdice/game_system.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/BadLife.rb 100.00% <100.00%> (+0.95%) ⬆️
...ce/game_system/beginning_idol/accessories_table.rb 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dadaffc...f16d161. Read the comment docs.

@ysakasin ysakasin marked this pull request as ready for review October 16, 2021 07:07
@ysakasin ysakasin merged commit 2a900f2 into master Oct 16, 2021
@ysakasin ysakasin deleted the fate_core_system branch October 16, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new dicebot 新システムの対応
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant