Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

失敗時のSL0表示を+0から-0に修正 #585

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

Faceless192x
Copy link
Contributor

WHコマンドの成功度判定について、失敗時にSLが0だったときルール上は「-0」表記しなくてはいけないが「+0」表記になっていた不具合の修正。

bundle exec rake test:dicebots target=Warhammer4 実行済み。

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 95.40% // Head: 95.40% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1e70004) compared to base (71532d4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #585   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         324      324           
  Lines       18296    18298    +2     
  Branches     4741     4743    +2     
=======================================
+ Hits        17456    17458    +2     
  Misses        840      840           
Impacted Files Coverage Δ
lib/bcdice/game_system/Warhammer4.rb 96.19% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ysakasin ysakasin added the 変更 動作の変更 label Nov 23, 2022
@ysakasin ysakasin merged commit 1dc9cbe into bcdice:master Nov 23, 2022
@ysakasin
Copy link
Member

@Faceless192x ありがとうございます。マージしました。

@Faceless192x Faceless192x deleted the update-Warhammer4 branch November 23, 2022 06:55
@Faceless192x
Copy link
Contributor Author

ありがとうございます!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
変更 動作の変更
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants