Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MonotoneMuseum]>=?判定を修正 #617

Merged
merged 1 commit into from
Apr 8, 2023
Merged

[MonotoneMuseum]>=?判定を修正 #617

merged 1 commit into from
Apr 8, 2023

Conversation

Aimsot
Copy link
Contributor

@Aimsot Aimsot commented Mar 30, 2023

問題点

目標値が不明の場合にクリティカル・ファンブルの判定ができず、2d6>=?[12,2]のように手動でクリティカル・ファンブル値を設定する場合は動作しませんでした。

変更点

  • 目標値が不明(0または?)の場合でもクリティカル・ファンブルの判定を行います。
  • 目標値が不明の場合は、成功・失敗の判定を行いません。
  • 目標値不明の場合でも、クリティカル・ファンブル値を設定して動作するように修正しました。

- 目標値不明(0 or ?)の場合でもクリティカル、ファンブルの判定を行う
- 目標値不明の場合、成功・失敗の判定は行わない
- クリティカル、ファンブル値を手動で設定した場合でも動作するように修正
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f11256a) 95.45% compared to head (741e73f) 95.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files         333      333           
  Lines       18623    18625    +2     
  Branches     4825     4827    +2     
=======================================
+ Hits        17777    17779    +2     
  Misses        846      846           
Impacted Files Coverage Δ
lib/bcdice/game_system/MonotoneMuseum.rb 98.36% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ysakasin ysakasin merged commit 4e2ed9f into bcdice:master Apr 8, 2023
@ysakasin
Copy link
Member

ysakasin commented Apr 8, 2023

ありがとうございます。マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants