Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

『砂塵戦機アーガス2ed.』のダイスにファンブル処理を追加しました。 #643

Merged
merged 9 commits into from
Nov 9, 2023

Conversation

Faceless192x
Copy link
Contributor

アーガス作者の潮屋様からの提案を元に、アーガス2ed.にサプリメントで追加されたファンブル処理を追加しました。
・各判定で振ったダイスがすべて8以上の場合はファンブル(自動失敗)となる

オーバーライドする都合上、アーガス1ed.のダイスに処理を若干追加しています。

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ad55636) 95.60% compared to head (431ef62) 95.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   95.60%   95.60%   -0.01%     
==========================================
  Files         341      341              
  Lines       19560    19582      +22     
  Branches     5094     5099       +5     
==========================================
+ Hits        18701    18722      +21     
- Misses        859      860       +1     
Files Coverage Δ
lib/bcdice/game_system/SajinsenkiAGuS.rb 100.00% <100.00%> (ø)
lib/bcdice/game_system/SajinsenkiAGuS2E.rb 97.14% <95.00%> (-2.86%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファンブルがあくまでサプリメント記載の追加ルールということなので、デフォルトの挙動は変えずにオプションの挙動として欲しいです。

サプリメントを持っていなかったり、採用していない人に混乱を招いてしまいます。

lib/bcdice/game_system/SajinsenkiAGuS2E.rb Outdated Show resolved Hide resolved
lib/bcdice/game_system/SajinsenkiAGuS2E.rb Outdated Show resolved Hide resolved
@Faceless192x
Copy link
Contributor Author

という訳で修正してみましたので、お手隙の時にご確認ください。

@ysakasin ysakasin self-assigned this Sep 26, 2023
@Faceless192x Faceless192x requested a review from ysakasin November 2, 2023 08:37
@Faceless192x
Copy link
Contributor Author

GitHubの使い方が良く判っていなくて、ご迷惑をおかけしたかもしれません……。

@ysakasin ysakasin merged commit 815dbd1 into bcdice:master Nov 9, 2023
8 checks passed
@ysakasin
Copy link
Member

ysakasin commented Nov 9, 2023

@Faceless192x
ありがとうございます。マージしました。

@Faceless192x Faceless192x deleted the update/AGuS2E branch November 11, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants