Update Insane_Korean translation #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
정발 용어로 수정
ysakasin
requested changes
Nov 10, 2023
There was a problem hiding this comment.
The unit test is failed. Please also update test/data/Insane_Korean.toml .
https://github.com/eidals224/BCDice/blob/patch-1/test/data/Insane_Korean.toml
Modified to Korean official release term
|
thank you. I just updated test/data/Insane_Korean.toml |
|
It is still failed. Please check output and fix difference between translation data and test data. |
|
Oh, I just fixed differences! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 341 341
Lines 19584 19584
Branches 5101 5101
=======================================
Hits 18723 18723
Misses 861 861
☔ View full report in Codecov by Sentry. |
정발 용어로 수정
ysakasin
approved these changes
Nov 10, 2023
Closed
|
@eidals224 Thank you for updating! It is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
한국 정발 용어로 수정
Modified to Korean official release terms