Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOP Vulnerability fixes #272

Merged
merged 1 commit into from
Oct 26, 2023
Merged

OOP Vulnerability fixes #272

merged 1 commit into from
Oct 26, 2023

Conversation

skylermcnamee-hibc
Copy link
Collaborator

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

Basic vulnerability fixes (ran npm audit fix)

Additional Notes:

  • Unit and e2e tests all pass (Electron)
  • Npm run build passes.
  • Npm run lint has no errors except for expected warnings
  • E2e tests in Edge without weird console errors
  • E2e tests in Firefox
  • E2e tests in Chrome

Please note that Firefox and Chrome had some console warnings (Firefox warned about localhost cookie rejection, and Chrome warned about domain mutation). My suspicion is that these are minor localhost/Cypress errors that won't happen after deployment, but I'll run my test suites in the DEV environment to be sure.

@skylermcnamee-hibc skylermcnamee-hibc marked this pull request as ready for review October 26, 2023 19:17
Copy link
Collaborator

@cyrilbravo cyrilbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ^^

@skylermcnamee-hibc skylermcnamee-hibc merged commit 6da3c5f into main Oct 26, 2023
3 checks passed
@skylermcnamee-hibc skylermcnamee-hibc deleted the vulnerability-fixes branch October 26, 2023 19:24
@skylermcnamee-hibc
Copy link
Collaborator Author

Confirmed in both Chrome and Firefox that the aforementioned console errors don't appear to show up in DEV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants