-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-307 Geocoder search in property filter #1279
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1279 +/- ##
==========================================
+ Coverage 59.66% 59.71% +0.04%
==========================================
Files 887 888 +1
Lines 23643 23652 +9
Branches 4273 4277 +4
==========================================
+ Hits 14106 14123 +17
+ Misses 9147 9139 -8
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Having issues with |
@@ -16,7 +16,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
node-version: [14.x] | |||
node-version: [14.19.3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fosol just curious if we don't specify the node version does it create an issue with our github workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github action was failing so I had to specify what worked locally.
Resolve build issue Node version Reduce coverage requirement
@LawrenceLau2020 I'll let you merge this when you want it. I don't have time to add additional unit tests regrettably. |
@Fosol it seems we cannot merge the code unless we meet the codecov target of 60%, would we need to add new unit tests in order to meet the Codecov target of 60% to be able to merge this PR? |
@LawrenceLau2020 Either we wait for me to find time to create additional unit tests, or we bypass the requirement. Up to you? |
@Fosol sure, would you be able to write the additional unit tests within the next 4 weeks? |
@LawrenceLau2020 I was able to add a few tests for the component I updated. It appears to be passing the coverage checks now. The only check that doesn't pass is the old |
Awesome, Jeremy, looks good! |
Description
The property search filter will now display address results as the user types. These address results are from Geocoder. This does not include results from inventory regrettably as this would be quite a bit more work. If I can find more time next week I may be able to add it.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
As you type in the address input for search it will make a request to Geocoder for results. It reuses the same component used in other areas to perform the same action. When you select a value it places it in the input.
Checklist: