-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1291 React Error Boundary #2193
Conversation
🚀 Deployment Information The React APP Image has been built with the tag: |
🚀 Deployment Information The API Image has been built with the tag: |
Code Climate has analyzed commit 2ead880 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.4%. View more on Code Climate. |
…will have the correct context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error page looks great and functions well.
🎯 Summary
PIMS-1291
Adds an Error Boundary that will catch rendering errors. If a rendering error occurs, it defaults to this page instead.
It does not catch errors in "logic", so if a page renders but other Javascript/Typescript code throws an error, it doesn't catch those.
Changes
Testing
🔰 Checklist