-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1869 BCA XREF #2734
PIMS-1869 BCA XREF #2734
Conversation
Code Climate has analyzed commit 6e8d617 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.5%. View more on Code Climate. |
🚀 Deployment Information The Express API Image has been built with the tag: |
🚀 Deployment Information The React APP Image has been built with the tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using the strata PID: 000-899-275
checked a few properties and they seem to match with the online BCA data.
Works really well.
🎯 Summary
PIMS-1869
Changes
Testing
This is tough to test without the BC Assessment data in local, but it's possible to test individual parts with some substitutions.
First you have to run the migration then load the XREF data.
Get the data from here:
https://catalogue.data.gov.bc.ca/dataset/parcelmap-bc-jurisdiction-roll-number-pid-cross-reference-table
You will have to log in to see it.
I loaded the data with dbeaver. There's an option by right-clicking a table to import data > from CSV
Make sure you only import the three columns that are needed. You'll need to map them to the correct columns or additional columns with the CSV names will be created.
API
localhost:5000/v2/tools/jur-roll-xref?pid=206814
Frontend
🔰 Checklist