Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1869 BCA XREF #2734

Merged
merged 7 commits into from
Oct 23, 2024
Merged

PIMS-1869 BCA XREF #2734

merged 7 commits into from
Oct 23, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Oct 22, 2024

🎯 Summary

PIMS-1869

Changes

  • Created table to host XREF data
  • Added controller and route to API to access this table
  • Updated the ParcelPopup component to select the BCA data depending on the return value from this table.
  • Tests and Documentation

Testing

This is tough to test without the BC Assessment data in local, but it's possible to test individual parts with some substitutions.

First you have to run the migration then load the XREF data.
Get the data from here:
https://catalogue.data.gov.bc.ca/dataset/parcelmap-bc-jurisdiction-roll-number-pid-cross-reference-table
You will have to log in to see it.
I loaded the data with dbeaver. There's an option by right-clicking a table to import data > from CSV
Make sure you only import the three columns that are needed. You'll need to map them to the correct columns or additional columns with the CSV names will be created.

API

  • Can test with Thunderclient or Postman. Use a GET request like this: localhost:5000/v2/tools/jur-roll-xref?pid=206814

Frontend

  • You can test this by substituting the BC Assessment data with some static dummy data. Just make sure that the location you click has a PID that will correspond to an existing jurisdiction and roll number in the dummy data.
  • I just copied the returned object from PROD for a strata, then made sure that the useBCAssessment hook in the frontend returned that data instead of making the BCA call.
  • After that, click on the same strata as you took the data from in PROD

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

codeclimate bot commented Oct 22, 2024

Code Climate has analyzed commit 6e8d617 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.5%.

View more on Code Climate.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2734. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2734. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the strata PID: 000-899-275
checked a few properties and they seem to match with the online BCA data.
Works really well.

@dbarkowsky dbarkowsky merged commit 2aad8e2 into main Oct 23, 2024
12 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1869-BCA-XREF branch October 23, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants