Codecov fix via curl #507
Merged
Codecov fix via curl #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/api-dotnetcore.yml
Outdated
| env_vars: C# | ||
| # Specify whether or not CI build should fail if Codecov runs into an error during upload | ||
| fail_ci_if_error: true | ||
| run: | |
There was a problem hiding this comment.
is there an issue number or something detailing what is broken?
There was a problem hiding this comment.
What I mean is, is this a known issue with the codecov-action?
There was a problem hiding this comment.
Sort of, I have a few threads of people with the same issue with no resolution. Will post below. Think my most recent changes screwed something up though. Added some flags and messed up the syntax.
There was a problem hiding this comment.
There was a problem hiding this comment.
you can probably test the curl from your local machine once you generate the testing artifacts.
Codecov Report
@@ Coverage Diff @@
## dev #507 +/- ##
=======================================
Coverage 63.31% 63.31%
=======================================
Files 378 378
Lines 10387 10387
Branches 894 894
=======================================
Hits 6577 6577
Misses 3538 3538
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Heads up: updating to codecov-action@1.0.13 seemed to solve the issue: hyperledger-archives/aries-framework-go#2206 |
Fosol
approved these changes
Sep 24, 2020
devinleighsmith
approved these changes
Sep 24, 2020
Fosol
added a commit
that referenced
this pull request
Oct 11, 2020
* Removing asanchezr from codeowner (#503) * Bump elliptic from 6.5.2 to 6.5.3 in /frontend (#499) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: frontend/package.json & frontend/package-lock.json to reduce vulnerabilities (#500) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SOCKJS-575261 - https://snyk.io/vuln/SNYK-JS-YARGSPARSER-560381 Co-authored-by: Jeremy Foster <jeremymfoster@hotmail.com> * fix: frontend/package.json & frontend/package-lock.json to reduce vulnerabilities (#501) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SERIALIZEJAVASCRIPT-570062 Co-authored-by: Goeme Nthomiwa <gnthomiwa@live.ca> * fix: frontend/package.json & frontend/package-lock.json to reduce vulnerabilities (#502) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-LODASH-590103 Co-authored-by: Goeme Nthomiwa <gnthomiwa@live.ca> * Fixing keycloak setup (#504) * Codecov fix via curl (#507) * Codecov fix via curl * Update codevoc actions * Resolve npm build issue. (#508) * Resolve npm build issue. * attempt to resolve typing error with any. * fix with partials instead. * PA-203 msql server memory issue (#509) Improving indexes Fixing seed script Fixing ef migration issue * PA-739 avoid redirect to mapview after saving (#505) * Adding bruce to code owners (#510) Generate .env files for tools * Remove Text, Add Tooltip to Reset Button (#511) * Resolve npm build issue. * attempt to resolve typing error with any. * fix with partials instead. * Add a new wrapper component to allow tooltips to be added to existing components easily. Remove text on reset button, add to tooltip. Reduce code duplication. * Correct npm warnings. * Add remaining tooltips. * update snapshots. * Default Map Center and zoom (#512) * Resolve npm build issue. * attempt to resolve typing error with any. * fix with partials instead. * Change the default map zoom, and center location. * add comment describing the new map default. * Apply prettier corrections. * prettier fix. (#513) * Update unit tests for parcel detail name and description fields. (#515) * pa-203 Fixing paging (#516) * Zoom out to show more results and filter by city (#519) * centering to BC * PA-748 Filter by city PA-636 Landing page zoom out to show results of filter * Fixing import config (#520) Updating make file * PA-750 Display Toast Feedback when saving user, unit tests (#517) * add react-toastify, and some toasts when a user is saved within PIMS. * PA-750 App/Tests providing toast feedback to save action. * correct test warning. * remove duplicate test. * correct toast usage. * lock down package versions. * lock down unrelated packages. * ensure tests pass. * Move toasts to customAxios as an optional parameter. * minor corrections. * Export grouped toast object containing relevant fields. * Fix bug, should return error message in axios catch. Co-authored-by: Smith <Devin.Smith@quartech.com> * PA - 749 (#518) * PA-749 disable unused roles. * change lookupcode logic. * prettier fixes. * Update migrations to look for sql scripts in {migration_name}/up and {migration_name}/down automatically. * make format of hook ouput consistent. Co-authored-by: Smith <Devin.Smith@quartech.com> * Pa 857 (#521) * PA-857 App infinite reload cycle Remove routing actions not using React router. * prettier fixes. * attempt to correct test failures. * remove redundant assertion. Co-authored-by: Smith <Devin.Smith@quartech.com> * Updating backup docs and config (#522) * PA-924 Fix zoom on cluster click (#524) * Remove building warning * setCurrentPage now only accepts number param * pa-201 Updating setup script (#525) * Integrate with geo coder to zoom to city on city filter (#527) * PIMS-809, 810 * PA-936 Settings up basic prometheus and grafana in the tools project (#529) * Parcel Detail form fixes - update evaluations to use react table. Highlight page errors. (#526) * PA-749 disable unused roles. * Update migrations to look for sql scripts in {migration_name}/up and {migration_name}/down automatically. * Swap custom table with react-table on parcel detail form. * remove merge lines. * test fixes. Co-authored-by: Smith <Devin.Smith@quartech.com> * PA-748 Fix city filter and zoom out for more results (#532) * Use Pims colors in toasts. (#534) * PA-749 disable unused roles. * Update migrations to look for sql scripts in {migration_name}/up and {migration_name}/down automatically. * remove merge lines. * Update toast styling to re-use PIMS color palette. Co-authored-by: Smith <Devin.Smith@quartech.com> * PA-240 Ensure consistent display of user name. (#531) * PA-936 Adding route to API Prometheus metrics (#533) * Create media breakpoints for dispose project stepper. (#535) * PA-749 disable unused roles. * Update migrations to look for sql scripts in {migration_name}/up and {migration_name}/down automatically. * remove merge lines. * Create some logical media breakpoints for different screen widths. All of these screen widths provide a reasonable looking stepper given available space. * refactor - stepper must be specific to disposal phase. Co-authored-by: Smith <Devin.Smith@quartech.com> * React Table filter paging fix, reset to page 0 when filter changes. (#536) * PA-749 disable unused roles. * Update migrations to look for sql scripts in {migration_name}/up and {migration_name}/down automatically. * remove merge lines. * Create some logical media breakpoints for different screen widths. All of these screen widths provide a reasonable looking stepper given available space. * refactor - stepper must be specific to disposal phase. * control the pageIndex of the various listviews in the application properly. * eslint fixes. * Ensure page numbers act consistently when controlled externally. Co-authored-by: Smith <Devin.Smith@quartech.com> * PIMS-937 * PIMS-951, 953 * SRES Navigation Items * PA-188 * Integration example * PA-982 Config API to send logs to Elasticsearch (#539) * Merging db migrations for release (#540) * PA-944 Add Help Functionality to PIMS. (#541) * Sensitive property changes (#537) * Update sensitive property radio button. * update based on ux feedback. * test updates. * Add url to strings.js to promote component reuse. fix variable typo. Co-authored-by: Jeremy Foster <jeremymfoster@hotmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Snyk bot <snyk-bot@snyk.io> Co-authored-by: Goeme Nthomiwa <gnthomiwa@live.ca> Co-authored-by: Jonny Toombs <jdtoombs@gmail.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> Co-authored-by: Smith <Devin.Smith@quartech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.