Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCFPCM-721] error running seeder on local #297

Merged
merged 2 commits into from
Nov 27, 2023
Merged

[CCFPCM-721] error running seeder on local #297

merged 2 commits into from
Nov 27, 2023

Conversation

chelsea-EYDS
Copy link
Collaborator

CCFPCM-721

Objective:

  • found a bug running the seeder on local
  • this only affects local development and does not need to be included in the release

byPassFileValidity: event.byPassFileValidity,
}));
const messages: ReconciliationEventMessage[] = listOfDays.map(
(date: Date) => ({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the type on 37

}
: {};
const config: S3ClientConfig = {
endpoint: process.env.AWS_ENDPOINT,
Copy link
Collaborator Author

@chelsea-EYDS chelsea-EYDS Nov 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during local development AWS_ENDPOINT='http://minio:9000/' (minio)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently showing as

AWS_ENDPOINT='http://minio:9000'

In .env.example. Good idea to change?

Copy link

sonarcloud bot commented Nov 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

}
: {};
const config: S3ClientConfig = {
endpoint: process.env.AWS_ENDPOINT,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently showing as

AWS_ENDPOINT='http://minio:9000'

In .env.example. Good idea to change?

@chelsea-EYDS chelsea-EYDS merged commit 27e4b80 into main Nov 27, 2023
5 checks passed
@chelsea-EYDS chelsea-EYDS deleted the CCFPCM-721 branch November 27, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants