-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform dashboard #202
platform dashboard #202
Conversation
Temporary Url for review: https://strr-platform-dev--pr-202-kinxn4mf.web.app |
|
9273257
to
9602869
Compare
Temporary Url for review: https://strr-platform-dev--pr-202-kinxn4mf.web.app |
9602869
to
a326b5c
Compare
Temporary Url for review: https://strr-platform-dev--pr-202-kinxn4mf.web.app |
Temporary Url for review: https://strr-platform-dev--pr-202-kinxn4mf.web.app |
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
9317bbf
to
42ea9da
Compare
Temporary Url for review: https://strr-platform-dev--pr-202-kinxn4mf.web.app |
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Quality Gate passedIssues Measures |
Temporary Url for review: https://strr-platform-dev--pr-202-kinxn4mf.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? 'text-lg' is 18px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so? We've got H1's as 1.25rem (20px) and H2's as 1.125rem (18px) in many places. The explicit '-32px' / '-24px' were originally from the strr-web project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong about this for sure though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay after looking at the other apps I think this is supposed to be 2rem for H1 and 1.5rem for H2, and then we can just override it for other cases where it varies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments but everything looks great!
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).