Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - hosts submit, tweaks #362

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

kialj876
Copy link
Collaborator

@kialj876 kialj876 commented Dec 9, 2024

Issue:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876 kialj876 requested a review from deetz99 December 9, 2024 15:32
Copy link

sonarqubecloud bot commented Dec 9, 2024

@kialj876 kialj876 requested a review from kris-daxiom December 9, 2024 15:32
Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of your change, but I see firstName is still mandatory?

Copy link
Collaborator

@deetz99 deetz99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kialj876
Copy link
Collaborator Author

kialj876 commented Dec 9, 2024

Not part of your change, but I see firstName is still mandatory?

I'll add this as an item to update that validation when I go back and tweak the business number. Was originally hoping to get the full name field in for mvp instead, but that's pretty low priority / requires backend updates

@kialj876 kialj876 merged commit 26a73bd into bcgov:main Dec 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants