-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All - UI: radio group position #410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new route meta option allows to abort the account change, so in this case we don't have to reset the old account if the user clicks cancel, but if they click continue we need to set the account id to the new one so that 'handleExternalRedirect' appends the correct account id
Temporary Url for review: https://strr-platform-dev--pr-410-00iqs1i9.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using functions in definePageMeta must be imported from outside the file as of now. I think nuxt 3.15.0 will allow inline functions.
Quality Gate passedIssues Measures |
Temporary Url for review: https://strr-platform-dev--pr-410-00iqs1i9.web.app |
Temporary Url for review: https://strr-hosts-dev--pr-410-w8xr0sy7.web.app |
Temporary Url for review: https://strr-platform-dev--pr-410-00iqs1i9.web.app |
Temporary Url for review: https://strr-strata-hotel-dev--pr-410-b3ng205u.web.app |
Temporary Url for review: https://strr-hosts-dev--pr-410-w8xr0sy7.web.app |
Temporary Url for review: https://strr-examiner-dev--pr-410-x4assjeh.web.app |
2 similar comments
Temporary Url for review: https://strr-examiner-dev--pr-410-x4assjeh.web.app |
Temporary Url for review: https://strr-examiner-dev--pr-410-x4assjeh.web.app |
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).