Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All - UI: radio group position #410

Merged
merged 4 commits into from
Dec 19, 2024
Merged

All - UI: radio group position #410

merged 4 commits into from
Dec 19, 2024

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Dec 19, 2024

Issue:

Description of changes:

  • bump core layer version to use account change route meta
  • fix radio group styling

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new route meta option allows to abort the account change, so in this case we don't have to reset the old account if the user clicks cancel, but if they click continue we need to set the account id to the new one so that 'handleExternalRedirect' appends the correct account id

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-410-00iqs1i9.web.app

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using functions in definePageMeta must be imported from outside the file as of now. I think nuxt 3.15.0 will allow inline functions.

@deetz99 deetz99 changed the title All - UI: Account change All - UI: radio group position Dec 19, 2024
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-410-00iqs1i9.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-410-w8xr0sy7.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-410-00iqs1i9.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-410-b3ng205u.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-410-w8xr0sy7.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-410-x4assjeh.web.app

2 similar comments
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-410-x4assjeh.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-410-x4assjeh.web.app

@deetz99 deetz99 merged commit 023df64 into bcgov:main Dec 19, 2024
42 of 43 checks passed
@deetz99 deetz99 deleted the account-change branch December 19, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants