-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/alcs 1858 update condition pills #2011
Conversation
@@ -83,10 +82,6 @@ export class DecisionConditionComponent implements OnInit, OnChanges { | |||
description: this.data.description ?? null, | |||
}); | |||
|
|||
if (this.showSingleDateField && this.dates.length > 0 && this.dates[0].date) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because singleDate field was removed from ApplicationDecisionConditionDto and replaced by dates.
@@ -83,10 +82,6 @@ export class DecisionConditionComponent implements OnInit, OnChanges { | |||
description: this.data.description ?? null, | |||
}); | |||
|
|||
if (this.showSingleDateField && this.dates.length > 0 && this.dates[0].date) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above:
Because singleDate field was removed from ApplicationDecisionConditionDto and replaced by dates.
@@ -56,10 +56,10 @@ export class DecisionConditionComponent implements OnInit, OnChanges { | |||
|
|||
form = new FormGroup({ | |||
securityAmount: this.securityAmount, | |||
singleDate: this.singleDate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's added at the end of the group:
form = new FormGroup({
securityAmount: this.securityAmount,
administrativeFee: this.administrativeFee,
description: this.description,
componentsToCondition: this.componentsToCondition,
singleDate: this.singleDate,
});
@@ -56,10 +56,10 @@ export class DecisionConditionComponent implements OnInit, OnChanges { | |||
|
|||
form = new FormGroup({ | |||
securityAmount: this.securityAmount, | |||
singleDate: this.singleDate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
form = new FormGroup({
securityAmount: this.securityAmount,
administrativeFee: this.administrativeFee,
description: this.description,
componentsToCondition: this.componentsToCondition,
singleDate: this.singleDate,
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conversations seem to be fixed. LGTM
PG functions to determine condition statuses, and UI implementation