Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SRWs / Notifications #937

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Add SRWs / Notifications #937

merged 2 commits into from
Sep 5, 2023

Conversation

dhaselhan
Copy link
Collaborator

  • Rename AppParcelType => ParcelType and share across all 3
  • Add lots of SRW stuff

Add SRWs / Notifications
606ff27 
* Rename AppParcelType => ParcelType and share across all 3
* Add lots of SRW stuff
mhuseinov
mhuseinov approved these changes Sep 5, 2023
View reviewed changes
...l-frontend/src/app/features/create-submission-dialog/create-submission-dialog.component.scss Outdated Show resolved Hide resolved
portal-frontend/src/app/features/notifications/edit-submission/edit-submission.component.ts Outdated Show resolved Hide resolved
...ices/apps/alcs/src/portal/notification-submission/notification-submission.controller.spec.ts Show resolved Hide resolved
services/apps/alcs/src/portal/notification-submission/notification-submission.controller.ts Outdated Show resolved Hide resolved
services/apps/alcs/src/providers/typeorm/migrations/1693608113088-add_notifications.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not notice comments for tables, is it in next MR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah Ill include it in the documents MR since that should be the last new table

@dhaselhan dhaselhan merged commit 3b2f224 into develop Sep 5, 2023
3 checks passed
@dhaselhan dhaselhan deleted the feature/ALCS-388 branch September 5, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuseinov mhuseinov mhuseinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @mhuseinov