Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS-484: Accessibility updates #1554

Draft
wants to merge 4 commits into
base: alpha
Choose a base branch
from
Draft

Conversation

ayumi-oxd
Copy link
Collaborator

@ayumi-oxd ayumi-oxd commented Dec 17, 2024

Jira Ticket:

CMS-484
CMS-485

Description:

  • CMS-484, 485: Contain an element with role=menuitem in an element with role=menu
    • Adding role to ul and li caused a warning: "Non-interactive elements should not be assigned interactive roles jsx-a11y/no-noninteractive-element-to-interactive-role" so changed these elements to div
  • CMS-488: Remove role=button from park photo gallery
    • Remove roll=button from div
    • Change the element around the image to button so that users can click/tab focus on each image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant