Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18449 - GP/SP registration modify #582
18449 - GP/SP registration modify #582
Changes from 21 commits
a87d37e
3486641
4f29a2a
a458164
58f4beb
f4e518f
81fb8f5
761fbd4
07761d4
e6d351e
d9e559f
8872339
3ac5019
be78b27
5a4439a
354e507
d64594a
0c5e936
081225c
79db398
0dfd9e7
4329b98
04d951f
3c6bb43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use computed properties here instead when checking isTypePartnership.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
James and I discussed this, and he's right, but I think leaving the code like this is also acceptable as it's clear what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "business or corporation unregistered in B.C." since we do not want this section now, only "existing B.C. business" now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check with Mihai if we are ever going to use this again. I think we might so I recommend disabling this code instead of deleting it, but confirm first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I see in the uxpin, "Don't make changes for Registries staff. Make the changes for SBC staff and clients."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Check warning on line 34 in tests/unit/HelpContactUs.spec.ts
GitHub Actions / linting (20.5.1)