Skip to content

Commit

Permalink
chore: update content and images (#586)
Browse files Browse the repository at this point in the history
* refactor: CredentialsLanding component: add heading card

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: add supplemental cards

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: add image and word wrapping

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: link styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsStepper component: deprecate routes

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: CredentialsStepper component: function naming

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: DigitalCredentials component: split into sub components

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add web socket component

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: re-add credential table

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: DigitalCredentials component: update types and imports

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add revocation dialogs

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add replacement dialogs

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: devcontainer config

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: bump version number

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: rename route for specificity

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: ran linter and fixed linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: make interface field optional

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: revert auto-formatting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: contain dialogs for DigitalCredentials component

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix code smells

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: address code review comments

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: revert autoformatting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update wording and styling to align with UX

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: feature flag credentials feature with mixin

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: add TOU dialog

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix test failiures and code comments

* chore: cleaup

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: mixin to access digital credential feature

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: entity menu styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: add loading indicators to digital credential route pages

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: reset dialog and functions

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: returl null if undefined

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: beef up conditional checks

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: spelling error

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: spelling error

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* 18284: digital business card (#552)

* refactor: CredentialsLanding component: add heading card

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: add supplemental cards

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: add image and word wrapping

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: link styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsStepper component: deprecate routes

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: CredentialsStepper component: function naming

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: DigitalCredentials component: split into sub components

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add web socket component

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: re-add credential table

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: DigitalCredentials component: update types and imports

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add revocation dialogs

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add replacement dialogs

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: devcontainer config

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: bump version number

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: rename route for specificity

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: ran linter and fixed linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: make interface field optional

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: revert auto-formatting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: contain dialogs for DigitalCredentials component

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix code smells

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: address code review comments

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: revert autoformatting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update wording and styling to align with UX

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: feature flag credentials feature with mixin

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: add TOU dialog

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix test failiures and code comments

* chore: cleaup

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: mixin to access digital credential feature

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: entity menu styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: add loading indicators to digital credential route pages

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: reset dialog and functions

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: returl null if undefined

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: beef up conditional checks

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: spelling error

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: spelling error

Signed-off-by: Akiff Manji <amanji@petridish.dev>

---------

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: cleanup spelling and handle edge cases

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: failing tests

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: entity menu logic

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* 18284 Updated CSP (#561)

- added wss://*.gov.bc.ca to connect-src

* refactor: remove websocket support in favour of interval polling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: remove console log

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: address PR comments

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: remove unused import

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: build and test failures

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: digital business card (#562)

* refactor: CredentialsLanding component: add heading card

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: add supplemental cards

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: add image and word wrapping

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsLanding component: link styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: CredentialsStepper component: deprecate routes

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: CredentialsStepper component: function naming

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: DigitalCredentials component: split into sub components

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add web socket component

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: re-add credential table

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: DigitalCredentials component: update types and imports

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add revocation dialogs

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: DigitalCredentials component: add replacement dialogs

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: devcontainer config

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: bump version number

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: rename route for specificity

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: ran linter and fixed linting errors

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: make interface field optional

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: revert auto-formatting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: contain dialogs for DigitalCredentials component

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix code smells

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: address code review comments

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: revert autoformatting

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update wording and styling to align with UX

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: feature flag credentials feature with mixin

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: add TOU dialog

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix test failiures and code comments

* chore: cleaup

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: mixin to access digital credential feature

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: entity menu styling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: add loading indicators to digital credential route pages

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: reset dialog and functions

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: returl null if undefined

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: beef up conditional checks

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: spelling error

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: spelling error

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: cleanup spelling and handle edge cases

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: failing tests

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: entity menu logic

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* refactor: remove websocket support in favour of interval polling

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: remove console log

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: address PR comments

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: remove unused import

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* fix: build and test failures

Signed-off-by: Akiff Manji <amanji@petridish.dev>

---------

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* Update EntityMenu.spec.ts

* chore: remove web socket references

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: fix spacing

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: some cleanup

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* feat: credential detailed instructions

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: add tags to components

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: minor content updates

Signed-off-by: Akiff Manji <amanji@petridish.dev>

* chore: update package version

Signed-off-by: Akiff Manji <amanji@petridish.dev>

---------

Signed-off-by: Akiff Manji <amanji@petridish.dev>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
  • Loading branch information
amanji and severinbeauvais authored Nov 17, 2023
1 parent afd11a4 commit 2a63d04
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 21 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.0.14",
"version": "7.0.15",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
Binary file added src/assets/images/bc_wallet_app.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/assets/images/business_card_feature.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 7 additions & 1 deletion src/components/DigitalCredentials/CredentialsDetailSteps.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@
>mdi-open-in-new</v-icon></a> is a digital identity wallet. It lets you receive, store and present
digital credentials such as memberships, permits, and ID cards.
</p>
<div>
<div class="d-flex">
<img
src="@/assets/images/bc_wallet_app.png"
width="36px"
alt="BC Wallet app icon"
class="mr-2"
>
<v-btn
color="primary"
href="https://www2.gov.bc.ca/gov/content/governments/government-id/bc-wallet#get"
Expand Down
6 changes: 3 additions & 3 deletions src/components/DigitalCredentials/CredentialsLanding.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
cols="12"
sm="4"
md="5"
lg="6"
>
<img
width="100%"
Expand All @@ -21,7 +20,6 @@
cols="12"
sm="8"
md="7"
lg="6"
>
<h1>Business Card Credentials</h1>
<p class="mt-4">
Expand All @@ -42,7 +40,9 @@
large
@click="issueCredentials()"
>
<span>Get your Business Card Credential <v-icon>mdi-chevron-right</v-icon></span>
<span>Get your Digital Business Card
<v-icon>mdi-chevron-right</v-icon>
</span>
</v-btn>
</div>
</v-col>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<div class="align-self-center">2</div>
</span>
<span class="ml-8">
Scan the QR code with your BC Wallet to get your Digital Business Card and accept it in your BC
Scan the QR code with your BC Wallet app to get your Digital Business Card and accept it in your BC
Wallet app.
</span>
</v-card-text>
Expand Down
13 changes: 4 additions & 9 deletions src/components/DigitalCredentials/CredentialsStepper.vue
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,8 @@
/>
<p class="mt-8 justify-center text-center word-break-normal">
QR code isn't scanning?
<a
href="#"
@click.prevent="handleGenegerateNewQRCode()"
>
Generate a new QR code
</a>.
<!-- eslint-disable vue/max-attributes-per-line -->
<a href="#" @click.prevent="handleGenegerateNewQRCode()">Generate a new QR code</a>.
</p>
</v-card-text>
</v-card>
Expand Down Expand Up @@ -129,9 +125,8 @@
</div>
<p class="justify-center text-center word-break-normal pt-8">
Go to your
<router-link to="/digital-credentials">
credential dashboard
</router-link>
<!-- eslint-disable vue/singleline-html-element-content-newline -->
<router-link to="/digital-credentials">credential dashboard</router-link>
to see details and make changes.
</p>
</v-card-text>
Expand Down
4 changes: 2 additions & 2 deletions src/components/DigitalCredentials/CredentialsTable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
{{ item.isRevoked ? "Revoked" : item.isIssued ? "Issued" : "Pending" }}
</template>
<template #[`item.dateOfIssue`]="{ item }">
{{ apiToPacificDate(item.dateOfIssue) || "-" }}
{{ apiToPacificDateTime(item.dateOfIssue) || "-" }}
</template>
<template #[`item.action`]="{ item }">
<CredentialsMenu
Expand Down Expand Up @@ -73,7 +73,7 @@ export default class CredentialsTable extends Mixins(DateMixin) {
},
{
class: 'column-lg',
text: 'Date of Issue',
text: 'Issue Date',
value: 'dateOfIssue'
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
id="dialog-text"
class="warning-text"
>
This will revoke the credential from a BC Wallet. It cannot be reversed. Do you still wish to continue?
This will revoke the existing digital credential in a BC Wallet and send you another one.
It cannot be reversed. Do you still wish to continue?
</p>
</v-card-text>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
id="dialog-text"
class="warning-text"
>
This will revoke the credential from a BC Wallet. It cannot be reversed. Do you still wish to continue?
This will revoke the existing digital credential in a BC Wallet.
It cannot be reversed. Do you still wish to continue?
</p>
</v-card-text>

Expand Down

0 comments on commit 2a63d04

Please sign in to comment.