generated from bcgov/bcrs-template-ui
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
19034 rebase legal name branch #615
Merged
JazzarKarim
merged 55 commits into
bcgov:feature-legal-name
from
JazzarKarim:19034-rebase-legal-name-branch
Jan 29, 2024
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
208d19a
17347 - Move COA and COD corrections for COOPS into the generic corre…
seeker25 3f71127
17347 - Add in isCoop check for resume button. (#550)
seeker25 4ba88d2
18027 AGM Location change (#551)
ketaki-deodhar 8cc0025
AGM Location Change First PR (#553)
JazzarKarim 41653b7
AGM Location Change second PR (#554)
JazzarKarim 5ddb97b
AGM Location Change Third PR (#555)
JazzarKarim dad3a3e
AGM Location Change 4th and final PR (#556)
JazzarKarim 21b927d
AGM Location Change 5th PR for styling issues (#559)
JazzarKarim f9c0bb9
18024 Incremental AGM extension work (#558)
severinbeauvais a201be5
Make Certify block non-editable if non-staff user (AGM Filings) (#564)
JazzarKarim 72932ef
feat: digital business card (#566)
amanji 01128ba
18161 Updated in response to UXA notes (#567)
JazzarKarim b9f2404
16733 undefined placeholder for federal (#569)
jamespaologarcia 802a7b7
18024 Incremental AGM Extension changes (#568)
severinbeauvais c47cce4
18272 Add unit test for AboutTheBusiness component (#570)
leodube-aot 3fee14a
17917 Added placeholder for null values (#572)
jamespaologarcia 2cb369d
18024 Incremental AGM Extension changes (#571)
severinbeauvais 991add2
feat: digital credentials detailed instructions (#575)
amanji 0b936a4
18513 Fixed jerky expandable help transition (#576)
severinbeauvais 57c5eff
Extension Request Scenario 1 (#577)
JazzarKarim 6cf8c87
18369 agm extension evaluation (#573)
PaulGarewal 898d28c
17159 Update fetchNameRequest (#579)
kzdev420 039d828
18273 Extension Request Scenario 2 (#580)
leodube-aot 88a37fc
18469 Capitalize AGM in output titles (#581)
severinbeauvais 0c85638
18274 Updated To Do List and Recent Filing History (#584)
severinbeauvais 7a0c7c4
Update FilingHistoryList1.spec.ts
severinbeauvais 812bf56
18369 changed the duration of extension messages in accordance with U…
PaulGarewal 67e6031
18204 disable restore based on ff (#583)
jamespaologarcia 71a04be
chore: update content and images (#586)
amanji 7b929e3
fix: DBC feature should be available for historical companies (#587)
amanji df647c4
18273+18558 Extension Request Cleanup and Tests (#585)
leodube-aot 7190694
18024 - Fixed AGM Extensions in TODO List (#591)
JazzarKarim fa82ab9
18273+18558 Update Extension Request component UI (#592)
leodube-aot fade7ac
18534 Changes to support amalgamation applications (#590)
severinbeauvais 31f390b
18024 Finish AGM Extension UI implementation (#594)
leodube-aot bd33a82
feat: digital credentials gate (#595)
amanji d856738
18534 Amalg unit tests + small fixes + more typing (#596)
severinbeauvais 01fd5c0
feat: digital credentials TOU (#597)
amanji 25a623d
18782 fix error in wrong agm due date (#598)
tshyun24 3276960
17869 - Adding CFS account number BUSINESS-FILINGS-UI (#565)
AbrahamRostampoor 6a982a7
18833 agm ext calc (#599)
jamespaologarcia f09daf4
18805+18979 Amalgamate Button + Moved to amalgamationApplication + Se…
JazzarKarim a0a77eb
Create draft amalgamation + redirect + misc. fixes/updates (#601)
JazzarKarim 74afd2c
Updated Amalgamation Selection in response to UXA notes (#602)
JazzarKarim ccf0188
19005 Implemented historical - amalgamation reason text (#604)
severinbeauvais d12a12c
16967 Admin Freeze should not show on ledger (#603)
kzdev420 5f2d2b4
Update filingHistoryListStore.ts
severinbeauvais e114d81
16967 Set missing `displayLedger` property for draft apps (#605)
severinbeauvais 5091888
19190 Fixed "return to MBR" issues (#607)
severinbeauvais e069567
19291 Implemented "future effective amalgamation" alert (#608)
severinbeauvais 8caf1da
Added amalgamation FF check (#610)
JazzarKarim 9d6274f
19209 Pre-populate TING business + error handling (#609)
severinbeauvais a0ffb88
19204 Fixed whitespace between sub-title and body (#612)
severinbeauvais 6bf38e1
Bump vite from 4.3.9 to 4.5.2 (#613)
dependabot[bot] 00872a5
major upgrade to package version
JazzarKarim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
// README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node | ||
{ | ||
"name": "Node.js & TypeScript", | ||
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
"image": "mcr.microsoft.com/devcontainers/typescript-node:1-20-bullseye" | ||
|
||
// Features to add to the dev container. More info: https://containers.dev/features. | ||
// "features": {}, | ||
|
||
// Use 'forwardPorts' to make a list of ports inside the container available locally. | ||
// "forwardPorts": [], | ||
|
||
// Use 'postCreateCommand' to run commands after the container is created. | ||
// "postCreateCommand": "yarn install", | ||
|
||
// Configure tool-specific properties. | ||
// "customizations": {}, | ||
|
||
// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root. | ||
// "remoteUser": "root" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this file, it was different between main and the feature branch. I went ahead and combined both:
business-filings-ui/firebase.json
Line 23 in d455e43
https://github.com/bcgov/business-filings-ui/blob/feature-legal-name/firebase.json#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the legal name branch version includes "https://*.run.app" so it can talk to the legal name Legal API. We'll be able to remove that ultimately.
The main branch version probably included some digital business card stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't see anything specific for digital business card. The header now is exactly like main with the addition of
https://*.run.app
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, perfect.