19202 Removed details from Admin Freeze/Unfreeze filings #640
Conversation
- added paragraph - hide notation form - don't call ref methods if ref doesn't exist - don't save `details` - updated unit tests - removed unneeded code from TodoLlist.vue
| @@ -1019,9 +1019,6 @@ export default class TodoList extends Mixins(AllowableActionsMixin, DateMixin, E | |||
|
|
|||
| if (header) { | |||
| switch (header.name) { | |||
| case FilingTypes.ADMIN_FREEZE: | |||
| // do nothing for admin_freeze | |||
| break | |||
There was a problem hiding this comment.
Admin Freeze/Unfreeze filings will never appear in the Todo List because they cannot be saved as a draft.
| <v-divider | ||
| v-if="isCourtOrder" | ||
| class="mt-4" | ||
| /> |
There was a problem hiding this comment.
I moved this divider into the template block above (same v-if).
| If this filing is pursuant to a court order, enter the court order number. If this filing is pursuant | ||
| to a plan of arrangement, enter the court order number and select Plan of Arrangement. | ||
| </p> | ||
| <template v-if="!isAdministerFreeze"> |
There was a problem hiding this comment.
I wrapped both of these in a template with a single v-if, since they go together anyway,
| @@ -243,7 +243,7 @@ export default class AddStaffNotationDialog extends Mixins(DateMixin) { | |||
| } | |||
|
|
|||
| get notationLabel (): string { | |||
| if (this.isAdministrativeDissolution || this.isPutBackOn || this.isAdministerFreeze) { | |||
There was a problem hiding this comment.
There's no notation label for admin freeze.
| @@ -258,7 +258,7 @@ export default class AddStaffNotationDialog extends Mixins(DateMixin) { | |||
| // Administrative Dissolution, Put Back On, Freeze/Unfreeze Business require a detailed comment | |||
| (v: string) => ( | |||
| !!v || | |||
| (!this.isAdministrativeDissolution && !this.isPutBackOn && !this.isAdministerFreeze) || | |||
There was a problem hiding this comment.
There's no component, and thus no rules, for admin freeze. Ditto line 274 below.
| const isCourtOrderPoaValid = !this.isAdministerFreeze ? this.$refs.courtOrderPoaRef.validate() : true | ||
| const isNotationFormValid = (!this.$refs.notationFormRef || this.$refs.notationFormRef.validate()) | ||
| const isFileComponentValid = (!this.$refs.fileUploadRef || this.$refs.fileUploadRef.validate()) | ||
| const isCourtOrderPoaValid = (!this.$refs.courtOrderPoaRef || this.$refs.courtOrderPoaRef.validate()) |
There was a problem hiding this comment.
The above are each True if the component (ref) doesn't exist (and do not validate them).
| @@ -405,7 +405,6 @@ export default class AddStaffNotationDialog extends Mixins(DateMixin) { | |||
| } | |||
| } else if (this.isAdministerFreeze) { | |||
| filing[FilingTypes.ADMIN_FREEZE] = { | |||
| details: this.notation, | |||
There was a problem hiding this comment.
Do not save details.
severinbeauvais
requested review from
ketaki-deodhar,
jamespaologarcia,
vysakh-menon-aot and
PaulGarewal
|
| @@ -309,10 +309,10 @@ export default class AddStaffNotationDialog extends Mixins(DateMixin) { | |||
| this.enableValidation = false | |||
|
|
|||
| // reset notation form | |||
| this.$refs.notationFormRef.reset() | |||
| this.$refs.notationFormRef?.reset() | |||
There was a problem hiding this comment.
SonarCloud recommended using optional chaining instead of conditional syntax.
(Previous code was this.$refs.notationFormRef && this.$refs.notationFormRef.reset())
|
/gcbrun |
|
Temporary Url for review: https://business-filings-dev--pr-640-hnv61ev7.web.app SB says, try any active business, for example: |
Issue #: bcgov/entity#19202
Description of changes:
detailsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).