Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22248 - Disable codecov failure #678

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

JazzarKarim
Copy link
Collaborator

Issue #: /bcgov/entity#22248

Description of changes:

  • Disabled codecov failure

Following in the footsteps of Travis here: bcgov/sbc-auth#2806

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

@JazzarKarim JazzarKarim self-assigned this Jul 10, 2024
@JazzarKarim JazzarKarim changed the title 22248 disable codecov failure 22248 - disable codecov failure Jul 10, 2024
@JazzarKarim JazzarKarim changed the title 22248 - disable codecov failure 22248 - Disable codecov failure Jul 10, 2024
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

I think you don't have to increment the app version if you do Create and Edit UIs, since the deployed image isn't changing, but no harm in it either.

@JazzarKarim
Copy link
Collaborator Author

JazzarKarim commented Jul 10, 2024

Looks fine.

I think you don't have to increment the app version if you do Create and Edit UIs, since the deployed image isn't changing, but no harm in it either.

Makes sense. I'm thinking we also don't need to for the release. When deploying, we're technically not deploying anything with this commit. I'll revert it here and for the other 2 repos, not going to update it.

@JazzarKarim JazzarKarim merged commit 28ccc9e into bcgov:main Jul 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants