22446 Allow AR corrections (depending on FF) #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allowed Annual Report corrections for specified legal types only (per FF) - added new FF with default value
|
severinbeauvais
commented
Jul 25, 2024
| case EnumUtilities.isTypeAnnualReport(this.filing): | ||
| // enable AR corrections for specified legal types only | ||
| if (GetFeatureFlag('supported-ar-correction-entities').includes(this.getLegalType)) return false | ||
| return true |
There was a problem hiding this comment.
If the feature flag include the current legal type (eg, "CP") then don't disable the "File a Correction" menu item.
There was a problem hiding this comment.
Screenshot (from Dev):
severinbeauvais
commented
Jul 25, 2024
| @@ -18,6 +18,7 @@ const defaultFlagSet: LDFlagSet = { | |||
| 'supported-agm-location-chg-entities': [], | |||
| 'supported-amalgamation-entities': [], | |||
| 'supported-amalgamation-out-entities': [], | |||
| 'supported-ar-correction-entities': [], | |||
There was a problem hiding this comment.
Default value for the FF if LaunchDarkly cannot be reached: no entities are allowed to do AR corrections (which is safe -- we don't accidentally allow the feature).
Currently:
- in Dev, the FF is "CP"
- in Test, the FF is "CP"
- in Prod, the FF is ""
|
/gcbrun |
|
Temporary Url for review: https://business-filings-dev--pr-687-2aewcl50.web.app SB says, try this: https://business-filings-dev--pr-687-2aewcl50.web.app/CP1002537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#22446
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).