-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16978 Add valid parties to CORRECTION_CP_SPECIAL_RESOLUTION #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say I fully understand this, but it looks OK to me 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this specific to special resolution corrections as per the ticket requirements?
Yeah these are specific to special resolution corrections. It comes from task 2 in the ticket ("Update example business schema...") and is used for the new unit test. |
* added parties to CORRECTION_CP_SPECIAL_RESOLUTION * added 2 more parties to CORRECTION_CP_SPECIAL_RES * removed "partner" type * editing party list * Bump version to 2.18.11 * Cherry-pick 46fe420 --------- Co-authored-by: Leo Dube <leo.dube@aot-technologies.com> Co-authored-by: Vysakh Menon <vysakh.menon@aot-technologies.com>
Issue #: /bcgov/entity#16978
Description of changes:
The specific file to look at is schema_data.py, the rest is from the cherry-picked commit.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).