Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA fixes #74

Merged
merged 3 commits into from
Dec 7, 2023
Merged

QA fixes #74

merged 3 commits into from
Dec 7, 2023

Conversation

kialj876
Copy link
Collaborator

@kialj876 kialj876 commented Dec 6, 2023

*Issue:*bcgov/entity#18481
*Issue:*bcgov/entity#18664

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@kialj876 kialj876 self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@3a8a836). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage        ?   87.21%           
=======================================
  Files           ?       24           
  Lines           ?     1197           
  Branches        ?       59           
=======================================
  Hits            ?     1044           
  Misses          ?       96           
  Partials        ?       57           
Flag Coverage Δ
btr-ui 87.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kialj876
Copy link
Collaborator Author

kialj876 commented Dec 6, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-btr-dev--pr-74-9plsm4ih.web.app

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 force-pushed the 18481-18664-qa-fixes branch from beb8c20 to 7b52558 Compare December 7, 2023 00:07
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876
Copy link
Collaborator Author

kialj876 commented Dec 7, 2023

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-btr-dev--pr-74-9plsm4ih.web.app

@hfekete
Copy link
Collaborator

hfekete commented Dec 7, 2023

Nice !

Copy link
Collaborator

@patrickpeinanw patrickpeinanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kialj876 kialj876 merged commit db0085c into bcgov:main Dec 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants